Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error formatting for generic attribute missing errors #69700

Closed
333fred opened this issue Aug 24, 2023 · 3 comments · Fixed by #69735
Closed

Incorrect error formatting for generic attribute missing errors #69700

333fred opened this issue Aug 24, 2023 · 3 comments · Fixed by #69735
Labels
Area-Compilers Bug Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@333fred
Copy link
Member

333fred commented Aug 24, 2023

Version Used: 5fcefbe

Steps to Reproduce:

[SomeAttribute<int>] // error CS0246: The type or namespace name 'SomeAttribute<>Attribute' could not be found (are you missing a using directive or an assembly reference?)
void Foo() {}

Sharplab

Diagnostic Id: CS0246

Expected Behavior:

The type or namespace name 'SomeAttributeAttribute<>' could not be found (are you missing a using directive or an assembly reference?)

Actual Behavior:

The type or namespace name 'SomeAttribute<>Attribute' could not be found (are you missing a using directive or an assembly reference?)

@333fred 333fred added Bug Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. labels Aug 24, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 24, 2023
@333fred
Copy link
Member Author

333fred commented Aug 24, 2023

Important note: there is no issue with the actual check. SomeAttributeAttribute<T> resolves correctly. It's just the error message that's wonky.

@jcouv jcouv added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Aug 24, 2023
@jcouv jcouv added this to the Backlog milestone Aug 24, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 24, 2023
@kinkeadian25
Copy link
Contributor

kinkeadian25 commented Aug 27, 2023

Hi, been a bit to work on anything with roslyn cause I was getting up to speed on my new job, but ready to start working on my favorite project again! @CyrusNajmabadi, @jcouv, or @333fred. Is it cool if I take this one?

Edit: Went ahead and just subitted a PR

@CyrusNajmabadi
Copy link
Member

Is it cool if I take this one?

Totally :-)

@jcouv jcouv modified the milestones: Backlog, 17.8 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Bug Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants