Fix up handling for partially written generics #60789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
force-pushed
the
update-partial-generic-handling
branch
from
b1baaee to
7886251
Compare
jasonmalinowski
changed the title
jasonmalinowski
commented
Apr 16, 2022
Comment on lines
-114
to
-115
| stack++; | ||
| goto case SyntaxKind.GreaterThanToken; |
There was a problem hiding this comment.
FWIW, I did a test CI run seeing which tests had a >> token and returned true from this function -- we didn't have any until the tests I added it seems.
56 tasks
CyrusNajmabadi
approved these changes
Apr 16, 2022
We have some code to handle partially written generics where it could be a type but the compiler is still parsing it as an expression based on context. This code needed updating for the new unsigned shift operator, but while doing and adding tests I discovered it was broken if you called it while you were in the middle of what the compiler parsed as a shift operator. This fixes that issue too.
jasonmalinowski
force-pushed
the
update-partial-generic-handling
branch
from
7886251 to
c4e6ef5
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some code to handle partially written generics where it could be a type but the compiler is still parsing it as an expression based on context. This code needed updating for the new unsigned shift operator, but while doing and adding tests I discovered it was broken if you called it while you were in the middle of what the compiler parsed as a shift operator. This fixes that issue too.