Apply 'require accessibility modifiers' setting on interface methods #60226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
jasonmalinowski
approved these changes
Apr 18, 2022
| [WorkItem(47448, "https://github.com/dotnet/roslyn/issues/47448")] | ||
| [InlineData((int)AccessibilityModifiersRequired.ForNonInterfaceMembers)] | ||
| [InlineData((int)AccessibilityModifiersRequired.OmitIfDefault)] | ||
| public async Task TestModifierOnInterfaceMethods_03(int modifier) |
There was a problem hiding this comment.
Suggested change
| public async Task TestModifierOnInterfaceMethods_03(int modifier) | |
| public async Task TestModifierOnInterfaceMethods_03(int modifiersRequired) |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@maciek231 My apologies for the delay on this one; only comment was to rename a parameter and I'm happy to do so to save you the trouble of switching back to the branch. |
|
(letting tests re-run just since this got a bit stale) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47448