Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark public modifier on interface methods as unnecessary #47448

Closed
tmat opened this issue Sep 4, 2020 · 1 comment · Fixed by #76324
Closed

Mark public modifier on interface methods as unnecessary #47448

tmat opened this issue Sep 4, 2020 · 1 comment · Fixed by #76324
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone

Comments

@tmat
Copy link
Member

tmat commented Sep 4, 2020

Version Used:
Version 16.8.0 Preview 3.0 [30427.284.main]

Steps to Reproduce:

interface I
{
    public void F();
}

Expected Behavior:

public is marked as unnecessary.

Actual Behavior:

@tmat tmat added the Area-IDE label Sep 4, 2020
@tmat tmat changed the title Fade public modifier on interface methods as unnecessary Mark public modifier on interface methods as unnecessary Sep 4, 2020
@CyrusNajmabadi
Copy link
Member

we acutally have a setting for this: dotnet_style_require_accessibility_modifiers:for_non_interface_members.

We created the setting with the knowledge that DIM was coming, but i don't think it was ever hooked up to work. We should df impl it. If the value is not set to 'always' we should def also fade out.

@CyrusNajmabadi CyrusNajmabadi added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Sep 4, 2020
@sharwell sharwell added Concept-Continuous Improvement IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Sep 4, 2020
@sharwell sharwell added this to the Backlog milestone Sep 4, 2020
@github-project-automation github-project-automation bot moved this to InQueue in Small Fixes Oct 22, 2024
@github-project-automation github-project-automation bot moved this from InQueue to Completed in Small Fixes Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
Status: Completed
3 participants