Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a specialized display for anonymous delegates in C# #58908

Merged
merged 16 commits into from
Jan 18, 2022

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jan 18, 2022

Fixes #58871

Looks like:

image

This also unifies the behavior between C# and VB here.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review January 18, 2022 04:25
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 18, 2022 04:25
@@ -7925,7 +7926,49 @@ void M()
$$var v = (ref int i) => i.ToString();
}
}",
MainDescription("delegate string <anonymous delegate>(ref int)"));
MainDescription("delegate string <anonymous delegate>(ref int)"),
AnonymousTypes(""));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the top level we still show it like this. It's the inner references to an anonymous type that go in the Types: section.

@CyrusNajmabadi CyrusNajmabadi merged commit ae335c2 into dotnet:main Jan 18, 2022
@ghost ghost added this to the Next milestone Jan 18, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the anonDelDisplay branch January 20, 2022 20:26
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick info needs to show signatures of anonymous delegates.
3 participants