-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a specialized display for anonymous delegates in C# #58908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jan 18, 2022
@@ -7925,7 +7926,49 @@ void M() | |||
$$var v = (ref int i) => i.ToString(); | |||
} | |||
}", | |||
MainDescription("delegate string <anonymous delegate>(ref int)")); | |||
MainDescription("delegate string <anonymous delegate>(ref int)"), | |||
AnonymousTypes("")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the top level we still show it like this. It's the inner references to an anonymous type that go in the Types:
section.
CyrusNajmabadi
commented
Jan 18, 2022
src/Features/CSharp/Portable/LanguageServices/CSharpStructuralTypeDisplayService.cs
Outdated
Show resolved
Hide resolved
…TypeDisplayService.cs
davidwengier
approved these changes
Jan 18, 2022
…slyn into anonDelDisplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58871
Looks like:
This also unifies the behavior between C# and VB here.