Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to main-vs-deps #58729

Merged
merged 56 commits into from
Jan 10, 2022
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from main into main-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-main-vs-deps
git reset --hard upstream/main-vs-deps
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-main-vs-deps --force

333fred and others added 6 commits January 7, 2022 09:56
Closes #57802. Implements the GetTypesByMetadataName API, which returns all named types in the current compilation and referenced assemblies that match the given CLR metatdata name. Also updates the IDE's GetBestTypeByMetadataName to use this API under the hood, rather than the existing manual walk they were doing, simplyfing that codepath and proving out the API itself.
This was causing source indexers that use this API to make projects
to break when they ironically tried to index Roslyn itself.
Move suggestion mode configuration to state reset service
…-duplicate-handling

Deduplicate references in CommandLineProject.CreateProjectInfo
@dotnet-bot dotnet-bot requested review from a team as code owners January 8, 2022 00:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Jan 8, 2022
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @Cosifne

@dotnet-bot dotnet-bot enabled auto-merge January 8, 2022 00:02
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

Youssef1313 and others added 8 commits January 7, 2022 17:17
… source for `ReadOnlySpan<T>`. (#58724)

There is no such operator in real type. Instead `string` type declares an implicit conversion to ```ReadOnlySpan<char>```.
The mentioned PR has been merged a long time ago and we're
already using a newer version that includes that fix.

Co-authored-by: Tomáš Matoušek <[email protected]>
* Remove IntelliCodeCompletionOptions

* Remove PythiaCompletionProviderBase.HideAdvancedMembersOption
@dotnet-bot dotnet-bot requested a review from a team as a code owner January 10, 2022 18:23
@Cosifne Cosifne removed the Merge Conflicts There are merge conflicts with the base branch. label Jan 10, 2022
@dotnet-bot dotnet-bot merged commit a78db7b into main-vs-deps Jan 10, 2022
@ghost ghost added this to the Next milestone Jan 10, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.