Deduplicate references in CommandLineProject.CreateProjectInfo #58701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only code in here is testing CommandLineProject, but that was forwarded into Microsoft.CodeAnalysis.Workspaces awhile ago. So after moving these tests, the project is empty. The only thing that could be tested in Microsoft.CodeAnalysis.Workspaces.Desktop is our MEFv1 host services, but we already have enough implicit testing on that as it is. (Famous last words.)
This was causing source indexers that use this API to make projects to break when they ironically tried to index Roslyn itself.
jasonmalinowski
force-pushed
the
fix-metadata-reference-duplicate-handling
branch
from
1914e06 to
1f66342
Compare
ryzngard
approved these changes
Jan 7, 2022
ghost
added this to the 
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Mar 1, 2023
This matches the more or less equivalent change in Roslyn we did in dotnet#58701.
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Mar 1, 2023
…mmand arguments This matches the more or less equivalent change in Roslyn we did in dotnet#58701.
dibarbet
pushed a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Jun 8, 2023
This matches the more or less equivalent change in Roslyn we did in dotnet/roslyn#58701.
dibarbet
pushed a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Jun 8, 2023
…mmand arguments This matches the more or less equivalent change in Roslyn we did in dotnet/roslyn#58701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing source indexers that use this API to make projects to break when they ironically tried to index Roslyn itself.