Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/22051 Introduce Parameter #51357

Merged
merged 79 commits into from
Apr 19, 2021
Merged

Features/22051 Introduce Parameter #51357

Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
326a523
Have abstract introduce parameter completed?
akhera99 Feb 4, 2021
e479b92
currently adds a parameter to the method header
akhera99 Feb 4, 2021
b00bd7a
committing current changes, replaces expression with parameter
akhera99 Feb 8, 2021
7e2b825
Trying to annotate the expression
akhera99 Feb 9, 2021
5baa15c
Fixed an incorrect line where allOccurences should've been true
akhera99 Feb 9, 2021
72a8578
Removed unnecessary code, working on connecting expression back to pa…
akhera99 Feb 11, 2021
767fd77
MOdifies method calls in C#, currently adding VB support
akhera99 Feb 17, 2021
26f52a5
Adding VB items and associated tests
akhera99 Feb 20, 2021
3caf932
Moved find call sites to the abstract introduce parameter file since …
akhera99 Feb 20, 2021
9446775
Abstracted out the main function that calls all of the refactorings
akhera99 Feb 20, 2021
7b74c81
Added logic to make sure you're highlight an expression that has vari…
akhera99 Feb 20, 2021
1d7195f
Split into trampoline vs. not trampoline
akhera99 Feb 22, 2021
44ad100
Changes based on review comments
akhera99 Feb 22, 2021
a71d17a
Responded to more feedback, moved the methods that tied parameters to…
akhera99 Feb 23, 2021
4bfe528
Fixing changes made to incorrect file
akhera99 Feb 24, 2021
baadda5
Checking now to see if the expression has any variables before return…
akhera99 Feb 24, 2021
50908ef
Made changes to how rewrite is done, no longer only look at methoddec…
akhera99 Feb 27, 2021
32ca6a0
Added overload code
akhera99 Mar 2, 2021
35d72e5
Saving backup before changing annotations
akhera99 Mar 3, 2021
b77b093
Need to figure out why the spacing of the generated code gets weirdly…
akhera99 Mar 4, 2021
0db1e80
Removed annotations
akhera99 Mar 5, 2021
4e48c81
Added both trampolines, working on updating all occurrences
akhera99 Mar 10, 2021
64ef766
Now handles nested invocations
akhera99 Mar 11, 2021
df2a4e2
Changed logic surrounding creating the new expression
akhera99 Mar 15, 2021
0c504c9
Added final tests/optional param support
akhera99 Mar 20, 2021
ca7e9ff
Need to figure out what to do if getCurrentNode returns null
akhera99 Mar 22, 2021
4b9c785
Added some comments for items and did null checks
akhera99 Mar 22, 2021
cd0ed40
Fixed type mismatch
akhera99 Mar 22, 2021
bbfd2ae
formatting fixes
akhera99 Mar 22, 2021
3b08f76
Removed unnecessary code
akhera99 Mar 22, 2021
0347e5f
Changed file names
akhera99 Mar 22, 2021
bfd18f4
Responded to PR feedback
akhera99 Mar 23, 2021
f229270
Removed usages of the IntroduceParameterCodeAction
akhera99 Mar 24, 2021
22a633a
REmoved containskey cehck
akhera99 Mar 24, 2021
9863ee1
Redid what constituted a parameterized block, need to add tests
akhera99 Mar 24, 2021
7abc4cc
Changed code action titles, removed old, unused code action
akhera99 Mar 24, 2021
0f80777
Changed method name
akhera99 Mar 24, 2021
ef16690
A lot of changes based on feedback
akhera99 Mar 25, 2021
7bd8031
added comments regarding the point at which you introduce the parameter
akhera99 Mar 25, 2021
575c926
added one more example
akhera99 Mar 25, 2021
99f3e83
added tests for expression-bodied members
akhera99 Mar 26, 2021
a686136
More comments/better grammar
akhera99 Mar 26, 2021
01f6474
Was recomputing the dictionary twice
akhera99 Mar 26, 2021
c6b4780
Next pass, adding tests now
akhera99 Mar 30, 2021
dd689c4
Added a lot of tests
akhera99 Mar 30, 2021
80947f3
Need to fix a lot of tests, but now there are 2 code actions on the m…
akhera99 Mar 31, 2021
68e28c4
Fixed display text
akhera99 Mar 31, 2021
44f9a95
Fixed up C# tests, need to fix overload case
akhera99 Mar 31, 2021
927d496
Made sure the overload always returns something that is a statementsy…
akhera99 Mar 31, 2021
9f02412
Fixed tests, trampoline and overload now allow for optional parameters
akhera99 Apr 1, 2021
d7ece8a
Simplified the names of tests
akhera99 Apr 1, 2021
c0dd2a6
update the argument list directly instead of creating a new invocation
akhera99 Apr 1, 2021
863cc57
Removed comments and renamed
akhera99 Apr 1, 2021
0605a2d
fixes based on feedback, removed constructor usage for overload/extra…
akhera99 Apr 2, 2021
56b8206
added test for variable with a property, find locals differently
akhera99 Apr 2, 2021
175ee5e
local declaration is different parent for C# and VB, fixed VB tests
akhera99 Apr 2, 2021
3ac4a37
Fixed constructor case
akhera99 Apr 2, 2021
0738269
Fixed comments
akhera99 Apr 2, 2021
591722d
updated comment
akhera99 Apr 2, 2021
4ee8be4
Added cross-language test
akhera99 Apr 2, 2021
b96393d
Converted type tests
akhera99 Apr 2, 2021
5391063
responded to feedback
akhera99 Apr 6, 2021
25bb2ac
check for this/base/me expressions
akhera99 Apr 6, 2021
0bb14da
abstracted out repeated code
akhera99 Apr 6, 2021
3bbe19c
Added invocation accessor code
akhera99 Apr 8, 2021
08a680d
moved instant member reference check into semanticequivalence
akhera99 Apr 8, 2021
7541f4b
Removed unnecessary loop
akhera99 Apr 8, 2021
a5c984e
Added current test progress
akhera99 Apr 8, 2021
78dafa5
Added more tests and fixed some VB logic
akhera99 Apr 9, 2021
b893711
responded to feedback
akhera99 Apr 15, 2021
e1e8e55
Merge branch 'release/dev17.0' into features/22051_introduce_paramete…
akhera99 Apr 15, 2021
76789c4
Added with block test
akhera99 Apr 15, 2021
196e8bc
Merge branch 'features/22051_introduce_parameter_restart' of https://…
akhera99 Apr 15, 2021
efb98fc
converted to using enums, fixed generator
akhera99 Apr 15, 2021
6320b3f
removed comment
akhera99 Apr 16, 2021
a459695
Special casing destructor for VB
akhera99 Apr 16, 2021
f65ddf2
feedback
akhera99 Apr 16, 2021
4e45459
Added code refactoring provider names to fix failing test??
akhera99 Apr 16, 2021
fa3a928
changed priority group of code action test
akhera99 Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compilers/Test/Core/Traits/Traits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public static class Features
public const string CodeActionsInsertBraces = "CodeActions.InsertBraces";
public const string CodeActionsInsertMissingTokens = "CodeActions.InsertMissingTokens";
public const string CodeActionsIntroduceLocalForExpression = "CodeActions.IntroduceLocalForExpression";
public const string CodeActionsIntroduceParameter = "CodeActions.IntroduceParameter";
public const string CodeActionsIntroduceUsingStatement = "CodeActions.IntroduceUsingStatement";
public const string CodeActionsIntroduceVariable = "CodeActions.IntroduceVariable";
public const string CodeActionsInvertConditional = "CodeActions.InvertConditional";
Expand Down
Loading