Code

Features/22051 Introduce Parameter#51357

Code

Merged

akhera99 merged 79 commits intodotnet:release/dev17.0dotnet/roslyn:release/dev17.0from akhera99:features/22051_introduce_parameter_restartakhera99/roslyn:features/22051_introduce_parameter_restartCopy head branch name to clipboardApr 19, 2021

+4,121-2

Commits

Commits on Apr 9, 2021

• Have abstract introduce parameter completed?

  akhera99

  committed
  326a523

• currently adds a parameter to the method header

  akhera99

  committed
  e479b92

• committing current changes, replaces expression with parameter

  akhera99

  committed
  b00bd7a

• Trying to annotate the expression

  akhera99

  committed
  7e2b825

• Fixed an incorrect line where allOccurences should've been true

  akhera99

  committed
  5baa15c

• Removed unnecessary code, working on connecting expression back to parameters

  akhera99

  committed
  72a8578

• MOdifies method calls in C#, currently adding VB support

  akhera99

  committed
  767fd77

• Adding VB items and associated tests

  akhera99

  committed
  26f52a5

• Moved find call sites to the abstract introduce parameter file since it was not language dependent

  akhera99

  committed
  3caf932

• Abstracted out the main function that calls all of the refactorings

  akhera99

  committed
  9446775

• Added logic to make sure you're highlight an expression that has variables

  akhera99

  committed
  7b74c81

• Split into trampoline vs. not trampoline

  akhera99

  committed
  1d7195f

• Changes based on review comments

  akhera99

  committed
  44ad100

• Responded to more feedback, moved the methods that tied parameters to variables to the abstract class because they no longer rely on language inherent items

  akhera99

  committed
  a71d17a

• Fixing changes made to incorrect file

  akhera99

  committed
  4bfe528

• Checking now to see if the expression has any variables before returning true

  akhera99

  committed
  baadda5

• Made changes to how rewrite is done, no longer only look at methoddeclarationsyntax, changed from trampoline to overload

  akhera99

  committed
  50908ef

• Added overload code

  akhera99

  committed
  32ca6a0

• Saving backup before changing annotations

  akhera99

  committed
  35d72e5

• Need to figure out why the spacing of the generated code gets weirdly untabbed

  akhera99

  committed
  b77b093

• Removed annotations

  akhera99

  committed
  0db1e80

• Added both trampolines, working on updating all occurrences

  akhera99

  committed
  4e48c81

• Now handles nested invocations

  akhera99

  committed
  64ef766

• Changed logic surrounding creating the new expression

  akhera99

  committed
  df2a4e2

• Added final tests/optional param support

  akhera99

  committed
  0c504c9

• Need to figure out what to do if getCurrentNode returns null

  akhera99

  committed
  ca7e9ff

• Added some comments for items and did null checks

  akhera99

  committed
  4b9c785

• Fixed type mismatch

  akhera99

  committed
  cd0ed40

• formatting fixes

  akhera99

  committed
  bbfd2ae

• Removed unnecessary code

  akhera99

  committed
  3b08f76

• Changed file names

  akhera99

  committed
  0347e5f

• Responded to PR feedback

  akhera99

  committed
  bfd18f4

• Removed usages of the IntroduceParameterCodeAction

  akhera99

  committed
  f229270

• REmoved containskey cehck

  akhera99

  committed
  22a633a

• Redid what constituted a parameterized block, need to add tests

  akhera99

  committed
  9863ee1

• Changed code action titles, removed old, unused code action

  akhera99

  committed
  7abc4cc

• Changed method name

  akhera99

  committed
  0f80777

• A lot of changes based on feedback

  akhera99

  committed
  ef16690

• added comments regarding the point at which you introduce the parameter

  akhera99

  committed
  7bd8031

• added one more example

  akhera99

  committed
  575c926

• added tests for expression-bodied members

  akhera99

  committed
  99f3e83

• More comments/better grammar

  akhera99

  committed
  a686136

• Was recomputing the dictionary twice

  akhera99

  committed
  01f6474

• Next pass, adding tests now

  akhera99

  committed
  c6b4780

• Added a lot of tests

  akhera99

  committed
  dd689c4

• Need to fix a lot of tests, but now there are 2 code actions on the menu and the trampoline only adds parameters that are relevant to the expression

  akhera99

  committed
  80947f3

• Fixed display text

  akhera99

  committed
  68e28c4

• Fixed up C# tests, need to fix overload case

  akhera99

  committed
  44f9a95

• Made sure the overload always returns something that is a statementsyntax

  akhera99

  committed
  927d496

• Fixed tests, trampoline and overload now allow for optional parameters

  akhera99

  committed
  9f02412

• Simplified the names of tests

  akhera99

  committed
  d7ece8a

• update the argument list directly instead of creating a new invocation

  akhera99

  committed
  c0dd2a6

• Removed comments and renamed

  akhera99

  committed
  863cc57

• fixes based on feedback, removed constructor usage for overload/extraction

  akhera99

  committed
  0605a2d

• added test for variable with a property, find locals differently

  akhera99

  committed
  56b8206

• local declaration is different parent for C# and VB, fixed VB tests

  akhera99

  committed
  175ee5e

• Fixed constructor case

  akhera99

  committed
  3ac4a37

• Fixed comments

  akhera99

  committed
  0738269

• updated comment

  akhera99

  committed
  591722d

• Added cross-language test

  akhera99

  committed
  4ee8be4

• Converted type tests

  akhera99

  committed
  b96393d

• responded to feedback

  akhera99

  committed
  5391063

• check for this/base/me expressions

  akhera99

  committed
  25bb2ac

• abstracted out repeated code

  akhera99

  committed
  0bb14da

• Added invocation accessor code

  akhera99

  committed
  3bbe19c

• moved instant member reference check into semanticequivalence

  akhera99

  committed
  08a680d

• Removed unnecessary loop

  akhera99

  committed
  7541f4b

• Added current test progress

  akhera99

  committed
  a5c984e

• Added more tests and fixed some VB logic

  akhera99

  committed
  78dafa5

Commits on Apr 15, 2021

• responded to feedback

  akhera99

  committed
  b893711

• Merge branch 'release/dev17.0' into features/22051_introduce_parameter_restart

  akhera99

  authored
  e1e8e55

• Added with block test

  akhera99

  committed
  76789c4

• Merge branch 'features/22051_introduce_parameter_restart' of https://github.com/akhera99/roslyn into features/22051_introduce_parameter_restart

  akhera99

  committed
  196e8bc

• converted to using enums, fixed generator

  akhera99

  committed
  efb98fc

Commits on Apr 16, 2021

• removed comment

  akhera99

  committed
  6320b3f

• Special casing destructor for VB

  akhera99

  committed
  a459695

• feedback

  akhera99

  committed
  f65ddf2

• Added code refactoring provider names to fix failing test??

  akhera99

  committed
  4e45459

• changed priority group of code action test

  akhera99

  committed
  fa3a928