-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev16.0-preview2 to master #31041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause Fixes #30895 This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs #30978 and #30979. This change adds a temporary workaround to the analyzer to handle this case specially. TODO: File a bug to track reverting the temporary workaround once #30978 and #30979 are fixed.
… members analyzer Fixes #30965
Handle event symbols with explicit interface implementation in unused…
Fix IndexOutOfRange exception in InvocationExpressionSignatureHelpProvider
Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles cl…
Add csharp_prefer_braces to .editorconfig
Unused members analyzer: Do not flag write-only properties that are n…
ghost
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev16.0-preview2 into master.
git fetch --all git checkout merges/dev16.0-preview2-to-master git reset --hard upstream/master git merge upstream/dev16.0-preview2 # Fix merge conflicts git commit git push merges/dev16.0-preview2-to-master --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.