Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev16.0-preview2 to master #31041

Merged
19 commits merged into from
Nov 8, 2018
Merged

Merge dev16.0-preview2 to master #31041

19 commits merged into from
Nov 8, 2018

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from dev16.0-preview2 into master.

git fetch --all
git checkout merges/dev16.0-preview2-to-master
git reset --hard upstream/master
git merge upstream/dev16.0-preview2
# Fix merge conflicts
git commit
git push merges/dev16.0-preview2-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

mavasani and others added 19 commits November 6, 2018 06:57
…ause

Fixes #30895

This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs #30978 and #30979. This change adds a temporary workaround to the analyzer to handle this case specially.

TODO: File a bug to track reverting the temporary workaround once #30978 and #30979 are fixed.
Handle event symbols with explicit interface implementation in unused…
Fix IndexOutOfRange exception in InvocationExpressionSignatureHelpProvider
Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles cl…
Add csharp_prefer_braces to .editorconfig
Unused members analyzer: Do not flag write-only properties that are n…
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit e20ee16 into master Nov 8, 2018
@ghost ghost deleted the merges/dev16.0-preview2-to-master branch November 8, 2018 08:30
@dotnet-bot dotnet-bot restored the merges/dev16.0-preview2-to-master branch November 8, 2018 12:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants