Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles cl… #30980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause Fixes dotnet#30895 This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs dotnet#30978 and dotnet#30979. This change adds a temporary workaround to the analyzer to handle this case specially. TODO: File a bug to track reverting the temporary workaround once dotnet#30978 and dotnet#30979 are fixed.
|
Tagging @davkean |
...VisualBasic/Portable/RemoveUnusedMembers/VisualBasicRemoveUnusedMembersDiagnosticAnalyzer.vb
Show resolved
Hide resolved
|
Ping @dotnet/roslyn-ide for reviews. |
sharwell
approved these changes
Nov 7, 2018
...VisualBasic/Portable/RemoveUnusedMembers/VisualBasicRemoveUnusedMembersDiagnosticAnalyzer.vb
Show resolved
Hide resolved
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...VisualBasic/Portable/RemoveUnusedMembers/VisualBasicRemoveUnusedMembersDiagnosticAnalyzer.vb
Outdated
Show resolved
Hide resolved
|
@jinujoseph for approval |
This was referenced Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ause
Fixes #30895
This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs #30978 and #30979. This change adds a temporary workaround to the analyzer to handle this case specially.
TODO: File a bug to track reverting the temporary workaround once #30978 and #30979 are fixed.Filed #30981