-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev16.0.x to master #30928
Merged
Merged
Merge dev16.0.x to master #30928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arp.EditorFeatures * Add Microsoft.CodeAnalysis.Editor.IDecompiledSourceService * Add basic implementation of the IDecompiledSourceService for C#: CSharpDecompiledSourceService * Move decompilation feature from MetadataAsSourceFileService to CSharpDecompiledSourceService
# Conflicts: # src/Features/CSharp/Portable/CSharpFeaturesResources.resx
…available literal
…e type arguments contain an anonymous type - such a type name is unspeakable. For reference types containing anonymous types, we can generate null.
LOC CHECKIN | dotnet/roslyn dev15.9.x | 20181101
Merge dev15.9.x to dev16.0.x
* Fix assertion message when missing a code action * Added CodeRefactoringHelpers from Cyrus * Added 'Introduce using statement' refactoring * xlf * Tests for 'Introduce using statement' refactoring * Offer refactoring on vertical selection of declaration line * Fleshed out tests * Enable refactoring in switch sections and for invalid embedded declarations * Removed accidental test complexity * Enabled introducing using statement for VB * Stop offering 'introduce using' on VB single-line If * Added single-line lambda tests * Document when it is that block helpers will be used * Remaining review fixes
Add missing binding redirects to csc.exe.config
Add support for default namespace to workspace
Code fix for CS8313, CS8363 (invalid default literal as case constant / pattern) to use another literal
Right now we only recognize /shared and /keepalive for these flags, but we allow '-' everywhere else as an option prefix, so we should do the same here.
…compiler Improved User Experience with "Navigate to decompiled sources"
@brettfo Checks roslyn-CI, windows_debug_vs-integration_prtest and windows_release_vs-integration_prtest failed. Please have a look. |
Avoid naming collisions in IPC channels
@brettfo Just wanted to check the status of this PR. |
* Expression tree reflike checks WIP * Move test from emit to semantics * Fix ExpressionTreeRefLikeWalker * Fix label indent * Add more tests * Move ExpressionTreeRefLikeWalker logic to DiagnosticsPass * Resolve TODOs in IsExpressionTree * Ignore BoundConversion when checking for ref structs in expression trees * Comment on the purpose of `!(node is BoundConversion)` * Add ErrorCode.ERR_ExpressionTreeCantContainRefStruct * Use new error code in DiagnosticsPass * Update tests * Add TypedReference tests * Replace IsByRefLikeType check with IsRestrictedType() check * Simplify VisitLambda * Add new diagnostics to ArglistTests.ExpressionTreeTest
ghost
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev16.0.x into master.
git fetch --all git checkout merges/dev16.0.x-to-master git reset --hard upstream/master git merge upstream/dev16.0.x # Fix merge conflicts git commit git push merges/dev16.0.x-to-master --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.