Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev16.0.x to master #30928

Merged
38 commits merged into from
Nov 6, 2018
Merged

Merge dev16.0.x to master #30928

38 commits merged into from
Nov 6, 2018

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from dev16.0.x into master.

git fetch --all
git checkout merges/dev16.0.x-to-master
git reset --hard upstream/master
git merge upstream/dev16.0.x
# Fix merge conflicts
git commit
git push merges/dev16.0.x-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

siegfriedpammer and others added 27 commits August 7, 2018 21:48
…arp.EditorFeatures

* Add Microsoft.CodeAnalysis.Editor.IDecompiledSourceService
* Add basic implementation of the IDecompiledSourceService for C#: CSharpDecompiledSourceService
* Move decompilation feature from MetadataAsSourceFileService to CSharpDecompiledSourceService
# Conflicts:
#	src/Features/CSharp/Portable/CSharpFeaturesResources.resx
…e type arguments contain an anonymous type - such a type name is unspeakable. For reference types containing anonymous types, we can generate null.
LOC CHECKIN | dotnet/roslyn dev15.9.x | 20181101
@dotnet-bot dotnet-bot requested review from a team as code owners November 2, 2018 12:00
jnm2 and others added 7 commits November 2, 2018 08:14
* Fix assertion message when missing a code action

* Added CodeRefactoringHelpers from Cyrus

* Added 'Introduce using statement' refactoring

* xlf

* Tests for 'Introduce using statement' refactoring

* Offer refactoring on vertical selection of declaration line

* Fleshed out tests

* Enable refactoring in switch sections and for invalid embedded declarations

* Removed accidental test complexity

* Enabled introducing using statement for VB

* Stop offering 'introduce using' on VB single-line If

* Added single-line lambda tests

* Document when it is that block helpers will be used

* Remaining review fixes
Add missing binding redirects to csc.exe.config
Add support for default namespace to workspace
Code fix for CS8313, CS8363 (invalid default literal as case constant / pattern) to use another literal
Right now we only recognize /shared and /keepalive for
these flags, but we allow '-' everywhere else as an option
prefix, so we should do the same here.
…compiler

Improved User Experience with "Navigate to decompiled sources"
@v-asdhin
Copy link

v-asdhin commented Nov 2, 2018

@brettfo Checks roslyn-CI, windows_debug_vs-integration_prtest and windows_release_vs-integration_prtest failed. Please have a look.

@v-asdhin
Copy link

v-asdhin commented Nov 5, 2018

@brettfo Just wanted to check the status of this PR.

RikkiGibson and others added 2 commits November 5, 2018 15:14
* Expression tree reflike checks WIP

* Move test from emit to semantics

* Fix ExpressionTreeRefLikeWalker

* Fix label indent

* Add more tests

* Move ExpressionTreeRefLikeWalker logic to DiagnosticsPass

* Resolve TODOs in IsExpressionTree

* Ignore BoundConversion when checking for ref structs in expression trees

* Comment on the purpose of `!(node is BoundConversion)`

* Add ErrorCode.ERR_ExpressionTreeCantContainRefStruct

* Use new error code in DiagnosticsPass

* Update tests

* Add TypedReference tests

* Replace IsByRefLikeType check with IsRestrictedType() check

* Simplify VisitLambda

* Add new diagnostics to ArglistTests.ExpressionTreeTest
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 2468ad7 into master Nov 6, 2018
@ghost ghost deleted the merges/dev16.0.x-to-master branch November 6, 2018 03:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.