Do not warn for double nullable supression #30936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Test
cston
approved these changes
Nov 2, 2018
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 7, 2018
…zyT-and-delegates * dotnet/dev16.0-preview2: (117 commits) Do not warn for double nullable supression (dotnet#30936) Add -shared and -keepalive compiler options (dotnet#30818) Introduce using statement (dotnet#30106) Skip BinaryFileErrorTest Skip ParseFileOnBinaryFile Merge fixup Add missing binding redirects to csc.exe.config Add comments for default namespace in workspace Fix variable name Merge fixups Add support for default namespace to workspace Addressing feedback from Cyrus Embed optimization data to external compiler dependencies Skip optimizing System.Threading.Tasks.Extensions Skip optimizing System.Threading.Tasks.Extensions Add cert for PKT=b03f5f7f11d50a3a RoslynTools 18526.1 Fix VS dependency deployment Fix msbuild test Deploy System.Runtime.CompilerServices.Unsafe ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDM decided we should not warn on unnecessary usage of
!, which includes!!.Closes #29902
@cston for review.