CA1852 warns on generated Program for top-level statements

[kronic]

Description

Can't get rid of error CA1852

Reproduction Steps

Create default console project.
add .editorconfig with
dotnet_diagnostic.CA1852.severity = error

Expected behavior

genrate program class sealed

Actual behavior

genrate program class no sealed

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[stephentoub]

Thanks. This is a bug in CA1852; it shouldn't be warning on the generated Program for top-level statements.

[julealgon]

@stephentoub do you have any idea about when this patch will be released?

[stephentoub]

I don't know. @mavasani?

[mavasani]

Tagging @jmarolf

[cremor]

This is still not fixed in SDK 7.0.102. But installing the NuGet package "Microsoft.CodeAnalysis.NetAnalyzers" 7.0.0 manually fixes it. Does the SDK not contain the release version of the NuGet package?

[jhartmann123]

@mavasani @jmarolf The issue still appears with SDK 7.0.200. It looks like the fix from #6278 is only on main, but not on the 7.x release branch.

Current main with check for the top level statements:

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SealInternalTypes.cs

Lines 58 to 67 in 50f62a9

	if (type.TypeKind is TypeKind.Class &&
	!type.IsAbstract &&
	!type.IsStatic &&
	!type.IsSealed &&
	!type.IsExternallyVisible() &&
	!type.HasAttribute(comImportAttributeType) &&
	!type.IsTopLevelStatementsEntryPointType())
	{
	candidateTypes.Add(type);
	}

Current branch release/7.0.1xx without this check:

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SealInternalTypes.cs

Lines 58 to 66 in 897aa84

	if (type.TypeKind is TypeKind.Class &&
	!type.IsAbstract &&
	!type.IsStatic &&
	!type.IsSealed &&
	!type.IsExternallyVisible() &&
	!type.HasAttribute(comImportAttributeType))
	{
	candidateTypes.Add(type);
	}

[dotnetshadow]

I'm still getting this issue.
#5628 (comment)

I think the way this issue has been handled is a bit of a mess. It's fixed, then not fixed for some servicing. It's then not included in SDK then it is then it's not... what is the ultimate status of this issue?

[buyaa-n]

FYI it is only fixed in .NET 8, never ported to 7.0 before except the #6504, we will try to add that fix in next 7.0 release.

[dotnetshadow]

Looks like this has been fixed

[JamieMagee]

This appears to have regressed in 7.0.302 (May 2023)

[mavasani]

@buyaa-n - did the code flow/branching into dotnet/sdk repo break?

[JamieMagee]

Here are some examples highlighting the regression:

• 7.0.203 passes
• 7.0.302 fails

[buyaa-n]

@buyaa-n - did the code flow/branching into dotnet/sdk repo break?

I don't really know how it is supposed to flow, I don't see the change added in 7.0.2 included in 7.0.3

[QuintinWillison]

I've also seen this (private repository, so I can't share a link). For what it's worth, I don't get this failing locally (Windows) but do get it failing in CI (Linux GitHub runner).

[menees]

One workaround is to add this #pragma at the top of the Program.cs file:

// CA1852 Type 'Program' can be sealed because it has no subtypes in its containing assembly and is not externally visible
#pragma warning disable CA1852

[buyaa-n]

Update: we are working on adding this to the next 7.0.3 release

[buyaa-n]

The fix merged into next 7.0.3 release, will be ported to 7.0.4 too

[Emeka-MSFT]

Update: we are working on adding this to the next 7.0.3 release

Can you also consider adding a test, so that it remains "fixed".

[mavasani]

Update: we are working on adding this to the next 7.0.3 release

Can you also consider adding a test, so that it remains "fixed".

The test was already added with original fix. The regression happened due to branching/code flow issue between this repo and the dotnet/sdk repo