Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig and analyzers #240

Merged
merged 14 commits into from
Nov 27, 2023
Merged

Add editorconfig and analyzers #240

merged 14 commits into from
Nov 27, 2023

Conversation

elsand
Copy link
Member

@elsand elsand commented Nov 9, 2023

No description provided.

@elsand elsand mentioned this pull request Nov 9, 2023
@elsand elsand linked an issue Nov 9, 2023 that may be closed by this pull request
Directory.Build.props Outdated Show resolved Hide resolved
@elsand
Copy link
Member Author

elsand commented Nov 24, 2023

Ser veldig bra ut, men jeg får en del CA1852-feil, og der ser ut til å være pga dotnet/roslyn-analyzers#6141

dotnet --version viser at jeg har 7.0.114 installert, som er forholdsvis gammel. Jeg antar du har en nyere hvor denne er fikset. Burde vi ha en global.json for å indikere minimum SDK-version?

Edit: installerte siste skrik av SDK-en (7.0.404) og det fikset problemet. Ikke helt lett å finne ut hvilken release av SDK-en hvor denne fiksen ble inkorporert (de rota det til og fikk den ikke merga inn i 7.0.3-branchen, slik at det først knakk i 7.0.302 av SDK-en), men det skal visstnok være i orden fra 7.0.304. Dette kan da kanskje være utgangspunkt for en global.json noe ala dette (inntil vi bumper til net80):

{
  "sdk": {
    "version": "7.0.304",
    "rollForward": "latestFeature",
    "allowPrerelease": true
  }
}

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
17.4% 17.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@elsand elsand merged commit 230eccd into main Nov 27, 2023
1 of 2 checks passed
@elsand elsand deleted the analyzers-and-editorconfig branch November 27, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Etablere lint/styleguide
2 participants