Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port changes from release/3.1 branch #1186

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Port changes from release/3.1 branch #1186

merged 3 commits into from
Oct 1, 2019

Conversation

ajaybhargavb
Copy link
Contributor

ajaybhargavb and others added 3 commits October 1, 2019 13:58
@ajaybhargavb
Default to MVC 3.0 when we can't detect the Razor configuration (#1167)
95b412e 
* Default to MVC 3.0 when we can't detect the Razor configuration.

- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration.
- Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two).

dotnet/aspnetcore#13291

* Set RazorLanguageServer default RazorVersion to 3.0
@NTaylorMullen @ajaybhargavb
Add Blazor partial class support in Visual Studio. (#1182)
73858cd 
- No longer mark declaration files as single file generators. Prior to this we relied on SingleFileGenerators to dynamically update the declaration files when .razor files changed. However, to make partial classes work we can no longer depend on declaration files being available because their existence causes us to have to mangle class names for opened documents; otherwise you get two files with same name and result in ambiguous definition errors.
- Stopped including declaration files as part of the users compilation. This was intended to make the design time experience operate more similar to how Blazor apps function at runtime (directly access each component instead of their declarations). We now rely on the background code generation effort built from the find all references work to supply users with strongly typed component names.
- Stop mangling class names for Visual Studio. Razor.VSCode has its own set of configurations which i'm not addressing as part of this changeset.
- Start generating components with the partial modifier to their class name to enable partial class support.
- Updated existing tests to expect partial modifier.

dotnet/aspnetcore#5487
@ajaybhargavb
Update baselines to unbreak tests (#1184)
0d1e0d6
@ajaybhargavb
Copy link
Contributor Author

These changes have already been reviewed and approved for the preview1 release.

@ajaybhargavb ajaybhargavb requested review from dougbu and mkArtakMSFT and removed request for pranavkm, rynowak and NTaylorMullen October 1, 2019 21:06
@ajaybhargavb
Copy link
Contributor Author

I am not authorized to merge this PR 😢

@mkArtakMSFT mkArtakMSFT merged commit 1e85487 into release/3.1-preview1 Oct 1, 2019
@ghost ghost deleted the ajbaaska/port-changes branch October 1, 2019 21:53
@ajaybhargavb ajaybhargavb added this to the 3.1.0-preview1 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaybhargavb @mkArtakMSFT @NTaylorMullen