Default to MVC 3.0 when we can't detect the Razor configuration #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration. - Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two). dotnet/aspnetcore#13291
ajaybhargavb
requested review from
NTaylorMullen and
rynowak
as code owners
ajaybhargavb
changed the title
| @@ -44,13 +50,17 @@ public static RazorConfiguration SelectConfiguration(Version version) | |||
| { | |||
| return MVC_2_0; | |||
| } | |||
| else if (version.Major == 2 && version.Minor == 1) | |||
| else if (version.Major == 2 && version.Minor >= 1) | |||
|
Hmm, just thinking out loud, do we have any MSBuild bits that default to non-3.0 for projects that aren't explicit? Could be a total goose chase but i'm thinking of the Razor build server and such on how it decides to build Razor bits where the Razor configuration isn't clear. |
|
I don't think we have that yet, we'd need a 5.X sdk and 5.X TFM since language version default is tied to TFM for us. |
I see |
|
Verified this in VS. It defaults to 3.0 when Razor configuration could not be determined. |
rynowak
approved these changes
Sep 30, 2019
ghost
deleted the
ajaybhargavb
added a commit
that referenced
this pull request
Oct 1, 2019
* Default to MVC 3.0 when we can't detect the Razor configuration. - Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration. - Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two). dotnet/aspnetcore#13291 * Set RazorLanguageServer default RazorVersion to 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/aspnetcore#13291
Working on verifying it in VS (As soon as I can build Razor on my borked machine)