Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize how ProjectSnapshotManager is updated #10101

Merged
merged 27 commits into from
Mar 18, 2024
Merged

Rationalize how ProjectSnapshotManager is updated #10101

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
606c24a
Add IProjectSnapshotManager.Update(...) and UpdateAsync(...) methods
DustinCampbell Mar 14, 2024
0d9dc9c
Remove unused ProjectSnapshotManagerBase mock
DustinCampbell Mar 14, 2024
24ef65d
Move ProjectSnapshotManagerBase.GetOpenDocuments() to IProjectSnapsho…
DustinCampbell Mar 14, 2024
ef27c28
RazorProjectInfoPublisher: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
f8a3451
Remove unneeded [Shared] attribute
DustinCampbell Mar 14, 2024
6658456
GeneratedDocumentPublisher: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
987ae03
OpenDocumentGenerator: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
0a371d5
MonitorProjectConfigurationFilePathEndpoint: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
39bef6e
RazorProjectService: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
705c0b1
SnapshotResolver: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
09d8595
Remove ProjectSnapshotManagerBase from LSP services
DustinCampbell Mar 14, 2024
3d737bd
EditorManagerListener: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
b078e98
Add TestProjectSnapshotManager Update(...) and UpdateAsync(...) methods
DustinCampbell Mar 14, 2024
92e49de
Add TestAccessor for EditorDocumentManagerListener
DustinCampbell Mar 14, 2024
a5c92ff
FallbackProjectManager: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
d00078f
ProjectSnapshotSynchronizationService: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
eb0bfbe
VisualStudioSolutionCloseChangeTrigger: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
580166c
ProjectWorkspaceStateGenerator: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
5a988b5
Remove a couple of unnecessary dispatcher uses
DustinCampbell Mar 14, 2024
36d5e3c
Add non-mutating methods to ProjectSnapshotManager.Updater
DustinCampbell Mar 14, 2024
35616cc
WindowsRazorProjectHostBase: Use IProjectSnapshotManager
DustinCampbell Mar 14, 2024
521b11f
Remove ProjectSnapshotManagerBase
DustinCampbell Mar 14, 2024
f70963e
Clean up ProjectSnapshotManager a bit
DustinCampbell Mar 14, 2024
3fd5977
Use PooledArrayBuilder in ProjectSnapshotManager
DustinCampbell Mar 14, 2024
be97476
Use record deconstruction in ProjectSnapshotManager
DustinCampbell Mar 14, 2024
583b8dc
Prefer static lambdas when updating project snapshot manager
DustinCampbell Mar 15, 2024
fb8eb56
Merge branch 'main' into project-manager-updates
DustinCampbell Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../src/Microsoft.AspNetCore.Razor.LanguageServer/Extensions/IServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ public static void AddDocumentManagementServices(this IServiceCollection service

// Add project snapshot manager
services.AddSingleton<IProjectEngineFactoryProvider, LspProjectEngineFactoryProvider>();
services.AddSingleton<ProjectSnapshotManagerBase, ProjectSnapshotManager>();
services.AddSingleton<IProjectSnapshotManager>(services => services.GetRequiredService<ProjectSnapshotManagerBase>());
services.AddSingleton<IProjectSnapshotManager, ProjectSnapshotManager>();
DustinCampbell marked this conversation as resolved.
Show resolved Hide resolved
}

public static void AddHandlerWithCapabilities<T>(this IServiceCollection services)
Expand Down