Rationalize how ProjectSnapshotManager is updated #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These APIs are intended to make it easier to update the project snapshot manager without a dispatcher. This will be used to get rid of ProjectSnapshotMangerBase.
This change removes ProjectSnapshotManagerBase, which requires several test updates to use the Update(...) and UpdateAsync(...) APIs.
ryzngard
reviewed
Mar 15, 2024
.../src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotManager.Updater.cs
Show resolved
Hide resolved
ryzngard
reviewed
Mar 15, 2024
...zor/src/Microsoft.AspNetCore.Razor.LanguageServer/Extensions/IServiceCollectionExtensions.cs
Show resolved
Hide resolved
ryzngard
reviewed
Mar 15, 2024
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/Documents/EditorDocumentManagerListener.cs
Show resolved
Hide resolved
ryzngard
reviewed
Mar 15, 2024
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/IProjectSnapshotManager.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Mar 15, 2024
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/IProjectSnapshotManager.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/Documents/EditorDocumentManagerListener.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotManager.Updater.cs
Show resolved
Hide resolved
ryzngard
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
Update(...)andUpdateAsync(...)toIProjectSnapshotManagerin order to streamline code that updates it. This means that it is no longer necessary to carry around aProjectSnapshotManagerDispatcherin order to updateIProjectSnapshotManager. There is further work needed to do away withProjectSnaapshotManagerDispatchercompletely, but this is a big step in the right direction.I took care to make the commit history meaningful, so it should be manageable for reviewers.