Bump VSSDK version #9460
Merged
Bump VSSDK version #9460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
the
Area-Infrastructure
tmeschter
approved these changes
May 3, 2024
|
I think we'll have to revert the Roslyn package bump before we can make this work. |
This type has been banned in newer versions of `Microsoft.VisualStudio.Sdk.Analyzers`. Use `ReentrantSemaphore` instead.
|
The Roslyn PR was reverted. I rebased this on main, fixed a conflict, and force-pushed an update. I'm going to take another stab at the Roslyn changes, but want to get this in first. |
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this pull request
May 24, 2024
Fixes AB#2065632 After updating the VSSDK in dotnet#9460, we converted a bunch of usages of `AsyncSemaphore` to `ReentrantSemaphore`. This has caused an issue in hot reload. The new semaphore class has several modes. We change from disallowing re-entrancy, so allowing freeform re-entrancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9424
We bump the VSSDK to 17.11. As part of this, we receive warnings to replace
AsyncSemaphorewithReentrantSemaphore. This PR includes that recommended change.Microsoft Reviewers: Open in CodeFlow