Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace occurrences of AsyncSemaphore with JTF-aware semaphore #9424

Closed
adamint opened this issue Mar 25, 2024 · 0 comments · Fixed by #9460
Closed

Replace occurrences of AsyncSemaphore with JTF-aware semaphore #9424

adamint opened this issue Mar 25, 2024 · 0 comments · Fixed by #9460
Assignees
@drewnoakes
Labels
Triage-Approved Reviewed and prioritized
Milestone
17.11

Comments

@adamint
Copy link
Member

adamint commented Mar 25, 2024

After updating our analyzer packages, using AsyncSemaphore is now banned. I tried to replicate the same behavior with an allowed type, but was running into test failures so assigning to @drewnoakes because I do not know this code very well.

In the meantime, I'm adding a suppression to our FUTDC usages of this type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
17.11
Development

Successfully merging a pull request may close this issue.

Bump VSSDK version drewnoakes/project-system
3 participants
@drewnoakes @melytc @adamint