Use modern unified settings format, upgrade packages & fix analyzer issues #9422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamint
force-pushed
the
dev/adamint/unified-settings-attribute
branch
from
11d5cc0 to
b3b7091
Compare
|
Converting back to draft, I need to look at all the errors. |
|
Could we split out the unified settings changes from the threading changes please? |
Not without disabling the threading errors @drewnoakes. I can disable and already filed #9424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates various packages required for a higher shell version. Moves our settings file to the expected location, with the expected name.
Newer analyzers ban the use of AsyncSemaphore. I was unable to easily replace this type with ReentrantSemaphore, so opened #9424 to track this and added exceptions to
GlobalSuppressions.cs.Microsoft Reviewers: Open in CodeFlow