Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the FabricBot config for migration to Policy Service #8855

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Feb 15, 2024

There are changes that need to be made to the FabricBot configuration before this repository is ready for migration to Policy Service. There is some lost functionality here, but it was minimized as much as possible.

  1. There were two tasks configured as event triggers that relied on noActivitySince that were removed
    • This relied on behavior of checking "no activity since X days, before this event," which is not a supported feature in Policy Service
    • In both cases, the automation would respond to the event on an issue that was stale before that event occurred
    • This automation is lost here and is not supported in the new service
  2. There was a task that filtered away issues that have been added to any GitHub Project (Classic), and that condition is no longer supported
    • The new service does not support automation around GitHub Projects (Classic)
    • This task was changed to skip that condition to apply the 'needs triage' label even if the issue is on a project
    • References to project events were also removed from the configuration, but they did not previously have an effect
  3. Explicitly filter for 'isPr' and 'isIssue' on all events
    • FabricBot used the "event_type" configuration setting to implicitly apply a filter, but the migration to Policy Service would lose that implicit filter
    • An explicit filter was added to add tasks where it otherwise could have been ambiguous
  4. A disabled task was deleted, as was a test task

@ReubenBond Sorry for the loss of functionality here, we did our best to minimize it.

/cc @wtgodbe @mkArtakMSFT @JohannesLampel

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
Copy link
Member

No problems, @jeffhandley - thank you for helping us with this!

@ReubenBond ReubenBond enabled auto-merge (squash) February 15, 2024 18:37
@ReubenBond ReubenBond disabled auto-merge February 15, 2024 18:38
@ReubenBond ReubenBond merged commit 639709e into dotnet:main Feb 15, 2024
15 of 19 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/fabricbot-prep branch February 23, 2024 05:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants