Enum.ToString method is resulting in slow performance. Fix it. #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimaTian
force-pushed
the
replace-enum-to-string
branch
from
3117080 to
878a618
Compare
baronfel
reviewed
Jan 6, 2025
jaredpar
reviewed
Jan 6, 2025
JanKrivanek
approved these changes
Jan 7, 2025
stephentoub
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We recently merged #11202
While profiling, the VS profiler started complaining about the Enum.ToString() with a perf cost 0.14%
See also here:
https://learn.microsoft.com/en-us/visualstudio/profiling/performance-insights-enum-tostring?view=vs-2022
Changes Made
Introduced a function to do the conversion in a Reflection-less way.