Enum.ToString method is resulting in slow performance. Fix it.

dotnet · Jan 6, 2025 · 3117080 · 3117080
1 parent 08729bf
commit 3117080
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Build/BackEnd/Components/RequestBuilder/TargetBuilder.cs b/src/Build/BackEnd/Components/RequestBuilder/TargetBuilder.cs
@@ -484,7 +484,7 @@ private async Task ProcessTargetStack(ITaskBuilder taskBuilder)
                             // Execute all of the tasks on this target.
                             MSBuildEventSource.Log.TargetStart(currentTargetEntry.Name);
                             await currentTargetEntry.ExecuteTarget(taskBuilder, _requestEntry, _projectLoggingContext, _cancellationToken);
-                            MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name, currentTargetEntry.Result?.ResultCode.ToString() ?? string.Empty);
+                            MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name, currentTargetEntry.Result?.TargetResultCodeToString(currentTargetEntry.Result.ResultCode) ?? string.Empty);
                         }
 
                         break;

diff --git a/src/Build/BackEnd/Shared/TargetResult.cs b/src/Build/BackEnd/Shared/TargetResult.cs
@@ -136,6 +136,21 @@ public TargetResultCode ResultCode
             }
         }
 
+        public string TargetResultCodeToString(TargetResultCode code)
+        {
+            switch (code)
+            {
+                case TargetResultCode.Failure:
+                    return "Failure";
+                case TargetResultCode.Skipped:
+                    return "Skipped";
+                case TargetResultCode.Success:
+                    return "Success";
+                default:
+                    return "";
+            }
+        }
+
         /// <summary>
         /// Returns the internal result for the target.
         /// </summary>