-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Build Submission Started event #10424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as an initial draft. It needs couple finalization steps:
- de/serialization of the event for node to node communication.
- de/serialization of the event for BinaryLogger (plus version increase)
- unit tests - for the de/serialization
- fixing the build failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There are couple adjustments needed (versioning, nullable strings ...) - captured in comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please add the created issue into the sprint - so that it gets handled soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #10145
Context
It is currently not possible to check for global variables during build execution. To have access to that data it needs to be passed on events to the processing nodes. None of the events we had previously were good matches to pass along this information, so it was decided to create one for build submission started, as this point in the build we have all properties loaded with the correct value, but its not too late to make use of them.
Changes Made
BuildSubmissionStartedEventArgs
based onBuildStatusEventArgs
and added it to the event handlers.BuildRequestDataFlags
was added toMicrosoft.Build.Framework
.Testing
To be added.
Notes
Blocker for #9747