MuxLogger discrepancy introduced by new event #10493
Labels
Area: BuildCheck
Area: Logging
Priority:2
Work that is important, but not critical for the release
triaged
MuxLogger and normal logger have output difference of a blank line with the introduction of new event. The test (here) was made more lenient so we could get work done without this being a blocker. This issue is being created to keep track of this difference and address it in the future.
Context
When adding the new event
BuildSubmissionStartedEventArgs
(#10424) an unintentional side effect was changing how the logging output looks like. This is happening because there is a difference in event order between loggers.Using the case of the
MockLogger
. TheMockLogger
will receive aBuildStartedEvent
, log it, and then receiveBuildSubmissionStartedEvent
, log it, and then receiveProjectStartedEvent
and log it.The MuxLogger will receive a
BuildStartedEvent
, ignore it, receive aBuildSubmissionStartedEvent
, log it, and then receiveProjectStartedEvent
when it will create an artificialBuildStartedEvent
that will then log before loggingProjectStartedEvent
.This causes the general event order to be different and for the outputs to be different.
The text was updated successfully, but these errors were encountered: