-
Notifications
You must be signed in to change notification settings - Fork 520
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AppKit] Add missing Accessibility protocols.
This commit adds a few protocols that were missing. It is interesting to mention that there are two of the protocols that are decorated with NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION, as per Apple documentation this means that: 'Unlike normal protocols, when you adopt one of the role-specific protocols, Xcode may ask you to reimplement methods that have already been implemented by one of your ancestors. In order to ensure that your control returns accurate and useful information, some methods are tagged with the NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION attribute. For these methods, you need to override your superclass’s implementation with your own. ' In this case, we need to add the methods from all the parent classes and set them to be [Abstract] since they are required. Not all methods have to be added ONLY the required ones. fixes: #7079
- Loading branch information
1 parent
21f7ef9
commit 00c4170
Showing
2 changed files
with
68 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00c4170
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2
🔥 Build failed 🔥