Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding is missing for INSAccessibilityCheckBox #7079

Closed
chamons opened this issue Sep 23, 2019 · 0 comments
Closed

Binding is missing for INSAccessibilityCheckBox #7079

chamons opened this issue Sep 23, 2019 · 0 comments
Assignees
@mandel-macaque
Labels
enhancement The issue or pull request is an enhancement macOS Issues affecting macOS
Milestone
Future

Comments

@chamons
Copy link
Contributor

chamons commented Sep 23, 2019

Note that bindings are present for the other 18 or so subclasses of NSAccessibility but INSAccessibilityCheckBox is missing, for some reason.

Originally: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/987346
@chamons chamons added enhancement The issue or pull request is an enhancement macOS Issues affecting macOS labels Sep 23, 2019
@chamons chamons added this to the Future milestone Sep 23, 2019
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this issue Sep 25, 2019
@mandel-macaque
[AppKit] Add missing Accessibility protocols.
00c4170 
This commit adds a few protocols that were missing. It is interesting to
mention that there are two of the protocols that are decorated with
NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION, as per Apple documentation
this means that:

'Unlike normal protocols, when you adopt one of the role-specific protocols,
 Xcode may ask you to reimplement methods that have already been implemented
 by one of your ancestors.

 In order to ensure that your control returns accurate and useful information,
 some methods are tagged with the NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION
 attribute. For these methods, you need to override your superclass’s
 implementation with your own.
'

In this case, we need to add the methods from all the parent classes and
set them to be [Abstract] since they are required. Not all methods have
to be added ONLY the required ones.

fixes: dotnet#7079
@mandel-macaque mandel-macaque mentioned this issue Sep 25, 2019
Merged
monojenkins pushed a commit to monojenkins/xamarin-macios that referenced this issue Oct 1, 2019
@mandel-macaque @monojenkins
[AppKit] Add missing Accessibility protocols.
2833c1a 
This commit adds a few protocols that were missing. It is interesting to
mention that there are two of the protocols that are decorated with
NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION, as per Apple documentation
this means that:

'Unlike normal protocols, when you adopt one of the role-specific protocols,
 Xcode may ask you to reimplement methods that have already been implemented
 by one of your ancestors.

 In order to ensure that your control returns accurate and useful information,
 some methods are tagged with the NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION
 attribute. For these methods, you need to override your superclass’s
 implementation with your own.
'

In this case, we need to add the methods from all the parent classes and
set them to be [Abstract] since they are required. Not all methods have
to be added ONLY the required ones.

fixes: dotnet#7079
@monojenkins monojenkins mentioned this issue Oct 1, 2019
Merged
chamons pushed a commit that referenced this issue Oct 2, 2019
@monojenkins @chamons
[d16-4] [AppKit] Add missing Accessibility protocols. (#7146)
c7d9fc1 
* [AppKit] Add missing Accessibility protocols.

This commit adds a few protocols that were missing. It is interesting to
mention that there are two of the protocols that are decorated with
NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION, as per Apple documentation
this means that:

'Unlike normal protocols, when you adopt one of the role-specific protocols,
 Xcode may ask you to reimplement methods that have already been implemented
 by one of your ancestors.

 In order to ensure that your control returns accurate and useful information,
 some methods are tagged with the NS_PROTOCOL_REQUIRES_EXPLICIT_IMPLEMENTATION
 attribute. For these methods, you need to override your superclass’s
 implementation with your own.
'

In this case, we need to add the methods from all the parent classes and
set them to be [Abstract] since they are required. Not all methods have
to be added ONLY the required ones.

fixes: #7079

* Remove the new methods.
@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mandel-macaque mandel-macaque

Labels
enhancement The issue or pull request is an enhancement macOS Issues affecting macOS
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@mandel-macaque @chamons