Check the correct interface list in IsInterfaceImplementationMarkedRecursively #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cursively `IsInterfaceImplementationMarkedRecursively` was incorrectly rewritten from a global prepass to a local interface walk in dotnet#1186. The new code was looking at the wrong interface list (looking at `IBar`'s interface list instead of `Bar`). We need to keep looking at the same interface list that we started with. Fixes dotnet#1421.
vitek-karas
approved these changes
Aug 11, 2020
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
…cursively (dotnet/linker#1429) `IsInterfaceImplementationMarkedRecursively` was incorrectly rewritten from a global prepass to a local interface walk in dotnet/linker#1186. The new code was looking at the wrong interface list (looking at `IBar`'s interface list instead of `Bar`). We need to keep looking at the same interface list that we started with. Fixes dotnet/linker#1421. Commit migrated from dotnet/linker@fc5e4aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsInterfaceImplementationMarkedRecursivelywas incorrectly rewritten from a global prepass to a local interface walk in #1186.The new code was looking at the wrong interface list (looking at
IBar's interface list instead ofBar). We need to keep looking at the same interface list that we started with.Fixes #1421.