-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch in keeping interfaces with explicit implementation #1421
Comments
This was referenced Aug 10, 2020
MichalStrehovsky
added a commit
to MichalStrehovsky/linker
that referenced
this issue
Aug 11, 2020
…cursively `IsInterfaceImplementationMarkedRecursively` was incorrectly rewritten from a global prepass to a local interface walk in dotnet#1186. The new code was looking at the wrong interface list (looking at `IBar`'s interface list instead of `Bar`). We need to keep looking at the same interface list that we started with. Fixes dotnet#1421.
MichalStrehovsky
added a commit
that referenced
this issue
Aug 12, 2020
…cursively (#1429) `IsInterfaceImplementationMarkedRecursively` was incorrectly rewritten from a global prepass to a local interface walk in #1186. The new code was looking at the wrong interface list (looking at `IBar`'s interface list instead of `Bar`). We need to keep looking at the same interface list that we started with. Fixes #1421.
tkapin
pushed a commit
to tkapin/runtime
that referenced
this issue
Jan 31, 2023
…cursively (dotnet/linker#1429) `IsInterfaceImplementationMarkedRecursively` was incorrectly rewritten from a global prepass to a local interface walk in dotnet/linker#1186. The new code was looking at the wrong interface list (looking at `IBar`'s interface list instead of `Bar`). We need to keep looking at the same interface list that we started with. Fixes dotnet/linker#1421. Commit migrated from dotnet/linker@fc5e4aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported in dotnet/runtime#40582.
I'm working on this right now, just filing an issue for tracking.
Simplified repro without regex:
Results in:
The text was updated successfully, but these errors were encountered: