Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Buildalyzer from CSharpProject #3112

Merged
merged 5 commits into from
Aug 26, 2023
Merged

Replace Buildalyzer from CSharpProject #3112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0110e6c
Add utilities to create Roslyn Workspace without binlogs
ocalles Aug 8, 2023
106570d
Remove Buildalyzer
ocalles Aug 8, 2023
31be419
Fix unit-tests
ocalles Aug 8, 2023
dd529dd
Code cleanup
ocalles Aug 21, 2023
cd211dc
Code cleanup
ocalles Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Microsoft.DotNet.Interactive.CSharpProject/Packaging/ProjectAsset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ private bool DidPerformCoreCompile(BuildDataResults result)
}

var sourceCount = result.BuildProjectData.SourceFiles?.Length ?? 0;
// TODO:
var compilerInputs = result.BuildProjectData.CompileInputs?.Length ?? 0;

return compilerInputs > 0 && sourceCount > 0;
Expand Down
5 changes: 2 additions & 3 deletions ...oft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ internal static BuildDataResults GetResultsFromCacheFile(string cacheFilePath)
CSharpParseOptions = cSharpParseOptions
};
}
catch (Exception)
catch (ArgumentNullException)
{
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we hiding an exception here at all? This is presumably happening due to a bug in our code.

}
Expand Down Expand Up @@ -172,8 +172,7 @@ public static CodeAnalysis.Project AddToWorkspace(BuildProjectData analyzerResul
ProjectInfo projectInfo = GetProjectInfo(analyzerResult, workspace, projectId);
if (projectInfo is null)
{
// Error
return null;
throw new ArgumentNullException(nameof(projectInfo));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the correct exception type, since it's not an argument.

What causes projectInfo to be null? Is it due to a bug somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push a cleanup pr to fix this

}
Solution solution = workspace.CurrentSolution.AddProject(projectInfo);

Expand Down