Replace Buildalyzer from CSharpProject #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
2 times, most recently
from
291986b to
8e6b37c
Compare
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
6 times, most recently
from
464a31f to
c65083c
Compare
Closed
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/BuildCacheFileUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 1, 2023
src/Microsoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
from
84194a3 to
cbf181b
Compare
|
@colombod Fixed the issue with Document Ids in the last commit. These are the 3 remaining unit-tests 
|
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
from
cc3989b to
31be419
Compare
|
I removed the last commit and did a git rebase onto upstream main to get the package upgrade in Markdig.Signed Can someone approve ? |
jonsequitur
reviewed
Aug 21, 2023
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 21, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
2 times, most recently
from
d74fa02 to
47aae5b
Compare
ocallesp
force-pushed
the
remove-buildalyzer-with-cache-file
branch
from
47aae5b to
dd529dd
Compare
jonsequitur
reviewed
Aug 22, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 22, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 22, 2023
...rosoft.DotNet.Interactive.CSharpProject/RoslynWorkspaceUtilities/RoslynWorkspaceUtilities.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Aug 25, 2023
| @@ -47,7 +47,7 @@ internal static BuildDataResults GetResultsFromCacheFile(string cacheFilePath) | |||
| CSharpParseOptions = cSharpParseOptions | |||
| }; | |||
| } | |||
| catch (Exception) | |||
| catch (ArgumentNullException) | |||
| { | |||
| return null; | |||
There was a problem hiding this comment.
Why are we hiding an exception here at all? This is presumably happening due to a bug in our code.
jonsequitur
reviewed
Aug 25, 2023
| @@ -172,8 +172,7 @@ public static CodeAnalysis.Project AddToWorkspace(BuildProjectData analyzerResul | |||
| ProjectInfo projectInfo = GetProjectInfo(analyzerResult, workspace, projectId); | |||
| if (projectInfo is null) | |||
| { | |||
| // Error | |||
| return null; | |||
| throw new ArgumentNullException(nameof(projectInfo)); | |||
There was a problem hiding this comment.
This isn't the correct exception type, since it's not an argument.
What causes projectInfo to be null? Is it due to a bug somewhere else?
There was a problem hiding this comment.
I'll push a cleanup pr to fix this
jonsequitur
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request seeks to eliminate all dependencies on Buildalyzer, due to its frequent breakdown during runtime. The instability can be attributed to frequent changes in the binlog format, necessitating either a regular update of Buildalyzer to the latest version supporting the new format, or the submission of respective updates to the Buildalyzer project repository.
This update involves numerous changes, the crux of which is a revision to the build process. During the build, a temporary file named Directory.Build.Targets is generated. This file initiates the creation of a target called DirectoryBuildTargetsContent which, in turn, generates a cache file containing all the necessary data to create a Roslyn Workspace object.
Subsequent to this update, instead of analyzing a binlog, the system reads from the cache file to create a Workspace, providing a more stable and efficient solution.