[ArPow] Build msbuild for net472 and remove dependency on VS component #12472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
reviewed
Oct 21, 2021
Comment on lines
4
to
7
| Subject: [PATCH] Restore building all TFMs for source-build to support NuGet | ||
| to support templating. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Is there an issue letting MSBuild know about this?
There was a problem hiding this comment.
No, We should push this to msbuild once we get the must have's for GA.
There was a problem hiding this comment.
Ok, I'll work on that. (I don't think this needs to block the PR, in the interest of getting a build through.)
There was a problem hiding this comment.
I'll work on that
Specifically, writing up an issue. 😄
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="all"/> | ||
| - <PackageReference Include="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.15" PrivateAssets="All" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" /> | ||
| + <PackageReference Include="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.15" PrivateAssets="All" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(DotNetBuildFromSource)' != 'true'" /> |
There was a problem hiding this comment.
Is this really necessary, with the directory being excluded in the src/Samples/Directory.Build.props change?
This seems to be about Microsoft.VisualStudio.SDK.EmbedInteropTypes rather than MS.VS.Setup.Configuration.Interop, should it go into its own patch?
Comment on lines
4
to
6
| Subject: [PATCH] Remove dependency on MS.VS.Setup.Configuration.Interop | ||
|
|
||
| --- |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichaelSimons
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#2542