Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building net472 (FullFrameworkTFM) during source-build #6979

Closed
dagood opened this issue Oct 21, 2021 · 3 comments
Closed

Enable building net472 (FullFrameworkTFM) during source-build #6979

dagood opened this issue Oct 21, 2021 · 3 comments
Labels

Comments

@dagood
Copy link
Member

dagood commented Oct 21, 2021

In source-build 5.0, there's a patch to remove the middle line here:

<LibraryTargetFrameworks>$(FullFrameworkTFM);netstandard2.0</LibraryTargetFrameworks>
<LibraryTargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">netstandard2.0</LibraryTargetFrameworks>
<LibraryTargetFrameworks Condition="'$(MonoBuild)'=='true'">$(FullFrameworkTFM)</LibraryTargetFrameworks>

We need to build net472 in 6.0, too, so we have this patch:

https://github.com/dotnet/installer/blob/9326af28148706e3e89ef2d61ebb6fc1adde21d9/src/SourceBuild/tarball/patches/msbuild/0003-Restore-building-all-TFMs-for-source-build.patch
(Added in dotnet/installer#12472)

This is needed for downstream repos to target net472 in source-build so Omnisharp will work:

I looked into the history a bit and it seems that this patch wasn't included in 6.0 ArPow onboarding simply because of a timing issue, not for any larger reason:

/cc @dotnet/source-build-internal @rainersigwald @eerhardt

@rainersigwald
Copy link
Member

No need to leave it as it is. I believe it's a vestige of earlier days when we didn't have the ReferenceAssemblies packages and it was hard to build for Framework on Core on non-Windows. But we're in the future now.

@eerhardt
Copy link
Member

NOTE: we will also need to tweak

<TargetFrameworks>net6.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(FullFrameworkTFM);net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(MonoBuild)'=='true'">$(RuntimeOutputTargetFrameworks)</TargetFrameworks>

Because it doesn't use $(LibraryTargetFrameworks). I believe we can just make those 3 lines:

 <TargetFrameworks>$(FullFrameworkTFM);net6.0</TargetFrameworks> 
 <TargetFrameworks Condition="'$(MonoBuild)'=='true'">$(RuntimeOutputTargetFrameworks)</TargetFrameworks> 

@AR-May AR-May added the triaged label Feb 21, 2024
@MichaelSimons
Copy link
Member

This isssue can be closed. Source-build now excludes all Full Fx TFMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants