You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I looked into the history a bit and it seems that this patch wasn't included in 6.0 ArPow onboarding simply because of a timing issue, not for any larger reason:
No need to leave it as it is. I believe it's a vestige of earlier days when we didn't have the ReferenceAssemblies packages and it was hard to build for Framework on Core on non-Windows. But we're in the future now.
In source-build 5.0, there's a patch to remove the middle line here:
msbuild/src/Directory.Build.props
Lines 29 to 31 in aac64bb
We need to build net472 in 6.0, too, so we have this patch:
https://github.com/dotnet/installer/blob/9326af28148706e3e89ef2d61ebb6fc1adde21d9/src/SourceBuild/tarball/patches/msbuild/0003-Restore-building-all-TFMs-for-source-build.patch
(Added in dotnet/installer#12472)
This is needed for downstream repos to target net472 in source-build so Omnisharp will work:
I looked into the history a bit and it seems that this patch wasn't included in 6.0 ArPow onboarding simply because of a timing issue, not for any larger reason:
/cc @dotnet/source-build-internal @rainersigwald @eerhardt
The text was updated successfully, but these errors were encountered: