Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Newtonsoft.Json code base #4764

Merged
merged 1 commit into from
Apr 25, 2018
Merged

remove Newtonsoft.Json code base #4764

merged 1 commit into from
Apr 25, 2018

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 20, 2018

This is the cause of a bunch of Watson failures in previews because we removed our direct dependency on Newtonsoft.Json.dll opting to instead use the version that ships with Visual Studio. If a user installed an earlier preview of 15.7 when Newtonsoft was included then upgraded to a newer preview, that file will have been removed, but the ProvideCodeBase attribute was still getting applied.

(I had previously misstated that the 'fix' was to drop the hive to force devenv.exe.config to get regenerated, but that is incorrect. The 'fix' was to manually drop the codeBase entry from the config file for the F# version of Newtonsoft.Json.)

@Pilchie
Copy link
Member

Pilchie commented Apr 20, 2018

Doesn't setup run devenv /updateconfigutation to force devenv.exe.config (along with the MEF cache, etc) to be created on each modification?

@Pilchie Pilchie added this to the 15.7 milestone Apr 20, 2018
@brettfo
Copy link
Member Author

brettfo commented Apr 20, 2018

@Pilchie, you're right. Talking with HeeJae the temporary fix was to remove the codeBase element from the config file. I've updated the description.

@brettfo brettfo changed the title [WIP] remove Newtonsoft.Json code base remove Newtonsoft.Json code base Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants