Visual Studio crashed in IncrementalAnalyzerProcessor #26171

nigurr · 2018-04-16T11:45:04Z

Version Used: 15.7 Preview 3

Steps to Reproduce:

Opening any project/solution crashes VS

Stack trace:

Application: devenv.exe
Framework Version: v4.0.30319
Description: The application requested process termination through System.Environment.FailFast(string message).
Message: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'StreamJsonRpc.JsonRpc'.
at Microsoft.Verify.NotDisposed(IDisposableObservable disposedValue, String message)
at StreamJsonRpc.JsonRpc.d__671.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task) at Microsoft.VisualStudio.LanguageServices.Remote.ServiceHubRemoteHostClient.<CreateWorkerAsync>d__11.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.VisualStudio.LanguageServices.Remote.ServiceHubRemoteHostClient.Connections.<RetryRemoteCallAsync>d__02.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.LanguageServices.Remote.ServiceHubRemoteHostClient.d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.LanguageServices.Remote.RemoteHostClientFactory.d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.LanguageServices.Remote.RemoteHostClientServiceFactory.RemoteHostClientService.d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.CodeAnalysis.Remote.RemoteHostClientExtensions.d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService.WorkCoordinator.IncrementalAnalyzerProcessor.NormalPriorityProcessor.d__37.MoveNext()
Stack:
at System.Environment.FailFast(System.String, System.Exception)
at Microsoft.CodeAnalysis.FailFast.OnFatalException(System.Exception)
at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception, System.Action1<System.Exception>) at Microsoft.CodeAnalysis.ErrorReporting.FatalError.ReportUnlessCanceled(System.Exception) at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor+<ResetStatesAsync>d__37.MoveNext() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task) at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor+<ResetStatesAsync>d__37.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor+<ResetStatesAsync>d__37, Microsoft.CodeAnalysis.Features, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<ResetStatesAsync>d__37 ByRef) at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor.ResetStatesAsync() at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor+<ExecuteAsync>d__17.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor+<ExecuteAsync>d__17, Microsoft.CodeAnalysis.Features, Version=2.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](<ExecuteAsync>d__17 ByRef) at Microsoft.CodeAnalysis.SolutionCrawler.SolutionCrawlerRegistrationService+WorkCoordinator+IncrementalAnalyzerProcessor+NormalPriorityProcessor.ExecuteAsync() at Microsoft.CodeAnalysis.SolutionCrawler.IdleProcessor+<ProcessAsync>d__12.MoveNext() at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef) at System.Threading.Tasks.Task.FinishContinuations() at System.Threading.Tasks.Task.FinishStageThree() at System.Threading.Tasks.Task1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].TrySetResult(System.Threading.Tasks.VoidTaskResult)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].SetResult(System.Threading.Tasks.VoidTaskResult) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].SetResult(System.Threading.Tasks.Task1<System.Threading.Tasks.VoidTaskResult>) at Microsoft.CodeAnalysis.SolutionCrawler.IdleProcessor+<WaitForIdleAsync>d__11.MoveNext() at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef) at System.Threading.Tasks.Task.FinishContinuations() at System.Threading.Tasks.Task.FinishStageThree() at System.Threading.Tasks.Task1[[System.Threading.Tasks.VoidTaskResult, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].TrySetResult(System.Threading.Tasks.VoidTaskResult)
at System.Threading.Tasks.Task+DelayPromise.Complete()
at System.Threading.Tasks.Task+<>c.b__274_1(System.Object)
at System.Threading.TimerQueueTimer.CallCallbackInContext(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.TimerQueueTimer.CallCallback()
at System.Threading.TimerQueueTimer.Fire()
at System.Threading.TimerQueue.FireNextTimers()
at System.Threading.TimerQueue.AppDomainTimerCallback()

I can share the repro machine/dump if required.

The text was updated successfully, but these errors were encountered:

heejaechang · 2018-04-16T18:50:41Z

Hi Thank you for reporting the issue?

can you share logs in %temp%\servicehub\logs? looks like some setup is messed up. the callstack shows VS is trying to start out of proc process and that failed to be started.

heejaechang · 2018-04-17T06:36:59Z

@jimmy9988 En-Shuo, have you reported this issue to FSharp team? it looks like somehow FSharp setup puts this in devenv.exe.config

			<dependentAssembly>
				<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral"/>
				<codeBase version="10.0.0.0" href="C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\Newtonsoft.Json.dll"/>
			</dependentAssembly>

but some VS drop doesn't have newtonsoft.json.dll in FSharp directory. causing everything that uses newtonsoft.json.dll in VS to fail.

another thing is that, it points to version 10.0.0.0 but config has binding redirect to 9.0.0.0

<dependentAssembly>
				<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral"/>
				<bindingRedirect oldVersion="1.0.0.0-9.0.0.0" newVersion="9.0.0.0"/>
			</dependentAssembly>

making 2 different versions of newtonsoft.json.dll to be used.

are these known issue?

tagging @jinujoseph @KevinRansom @brettfo

...

also, one of reliability bug @ivanbasov assigned to me (service hub failing to start) seems related to this.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/600984?src=WorkItemMention&src-action=artifact_link

heejaechang · 2018-04-17T06:38:05Z

@nigurr can you check your directory (C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\Newtonsoft.Json.dll) to see whether it has newtonsoft.json.dll ?

heejaechang · 2018-04-17T06:40:09Z

here are service hub logs @nigurr shared. basically multiple services fail due to newtonsoft.json.dll issue.

...

04/17/2018 10:26:15 : Error : Error creating Microsoft.VisualStudio.ExtensionManager.ServiceModule.ExtensionManagerServiceModule instance of CLR service module 'extensionManager': System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. HResult='-2146232828'
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at Microsoft.ServiceHub.HostLib.ServiceManager.CreateAndConfigureService(String name, Type serviceModuleType, WrappedStream stream)
===InnerException===
System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified. HResult='-2147024894'
at Microsoft.VisualStudio.ExtensionManager.ServiceModule.ExtensionManagerServiceModule..ctor(Stream serviceHubStream, IServiceProvider serviceProvider)

04/17/2018 10:26:16 : Error : Error creating Microsoft.CodeAnalysis.Remote.RemoteHostService instance of CLR service module 'roslynRemoteHost': System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. HResult='-2146232828'
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at Microsoft.ServiceHub.HostLib.ServiceManager.CreateAndConfigureService(String name, Type serviceModuleType, WrappedStream stream)
===InnerException===
System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified. HResult='-2147024894'
at Microsoft.CodeAnalysis.Remote.RemoteHostService..ctor(Stream stream, IServiceProvider serviceProvider)
04/17/2018 10:26:16 : Error : Error creating Microsoft.CodeAnalysis.Remote.SnapshotService instance of CLR service module 'roslynSnapshot': System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. HResult='-2146232828'
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at Microsoft.ServiceHub.HostLib.ServiceManager.CreateAndConfigureService(String name, Type serviceModuleType, WrappedStream stream)
===InnerException===
System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified. HResult='-2147024894'
at Microsoft.CodeAnalysis.Remote.SnapshotService..ctor(Stream stream, IServiceProvider serviceProvider)

nigurr · 2018-04-17T06:51:10Z

@heejaechang I am using latest public preview (15.7 PR 3) and Newton.Json doesn't exist in C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp

In 15.6 Stable release, the Newton.Json exists in that folder

jinujoseph · 2018-04-17T06:54:21Z

cc @Pilchie for info

heejaechang · 2018-04-17T06:55:15Z

@nigurr thank you

ping @KevinRansom @brettfo

according to @ivanbasov this is high priority

this is top crash in 15.7. preview 3 across the whole VS. Could you please take a look? It is a new regression started in 15.7 link

Pilchie · 2018-04-17T15:03:18Z

@brettfo deliberately removed that copy, so that F# would use the same version as everyone else, but it sounds like a the devenv.exe.config didn't get updated correctly?

Pilchie · 2018-04-17T15:03:56Z

Can we get a VSTS bug on this for shiproom tracking ASAP please?

brettfo · 2018-04-17T17:34:23Z

I think the Newtonsoft issue is a red herring. I've been running 15.7 previews for weeks and none of them have a copy of newtonsoft.json present.

The devenv.exe.config issue certainly needs to be fixed, but that would only cause issues at install time when everything is NGENed.

Edit:
The error logs above state that Newtonsoft.Json version 6 couldn't be found; F# used to ship (and doesn't any more) version 10, so this definitely isn't that issue.

heejaechang · 2018-04-17T18:45:47Z

I investigated this issue with @nigurr before. once we either copied newtonsoft.json to the FSharp folder or remove newtonsoft.json codebase to the FSharp folder, VS worked as expected.

@jimmy9988 can you copy over newtonsoft.json to the FSharp folder and see whether VS still crash?

brettfo · 2018-04-17T20:28:39Z

I have a new theory as to what happened:

A VS preview was installed with F# support back when F# shipped Newtonsoft.Json.dll and the appropriate entry was added to the hive-local devenv.exe.config.
The previews were upgraded past the point where Newtonsoft.Json.dll was no longer included.
devenv.exe.config was never regenerated.

@jimmy9988 Can you try again with a clean install of VS and after deleting your hives under %localappdata%\Microsoft\VisualStudio\15.0* and %appdata%\Microsoft\VisualStudio\15.0*`? If the problem still persists then I think the next step is to look into how/when devenv.exe.config is regenerated.

nigurr · 2018-04-18T07:03:05Z

@Pilchie I created DevDiv bug internally - 601243
Please update the details accordingly

@brettfo My machine has repro and we can investigate if you need any help (ping me)

jinujoseph · 2018-04-18T07:09:43Z

watson vso issue tracking this 600984

brettfo · 2018-05-02T17:30:53Z

Fixed in dotnet/fsharp#4764. The 15.7 release of VS will contain the fix.

jcouv added the Area-IDE label Apr 16, 2018

jinujoseph added this to the 15.7 milestone Apr 17, 2018

jinujoseph assigned KevinRansom Apr 17, 2018

jinujoseph added the Bug label Apr 17, 2018

dotnet deleted a comment from heejaechang Apr 17, 2018

Pilchie assigned brettfo and unassigned KevinRansom Apr 17, 2018

brettfo closed this as completed May 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visual Studio crashed in IncrementalAnalyzerProcessor #26171

Visual Studio crashed in IncrementalAnalyzerProcessor #26171

nigurr commented Apr 16, 2018

heejaechang commented Apr 16, 2018

heejaechang commented Apr 17, 2018 •

edited

Loading

heejaechang commented Apr 17, 2018

heejaechang commented Apr 17, 2018

nigurr commented Apr 17, 2018 •

edited

Loading

jinujoseph commented Apr 17, 2018

heejaechang commented Apr 17, 2018 •

edited by jinujoseph

Loading

Pilchie commented Apr 17, 2018

Pilchie commented Apr 17, 2018

brettfo commented Apr 17, 2018 •

edited

Loading

heejaechang commented Apr 17, 2018

brettfo commented Apr 17, 2018

nigurr commented Apr 18, 2018 •

edited

Loading

jinujoseph commented Apr 18, 2018

brettfo commented May 2, 2018

Visual Studio crashed in IncrementalAnalyzerProcessor #26171

Visual Studio crashed in IncrementalAnalyzerProcessor #26171

Comments

nigurr commented Apr 16, 2018

heejaechang commented Apr 16, 2018

heejaechang commented Apr 17, 2018 • edited Loading

heejaechang commented Apr 17, 2018

heejaechang commented Apr 17, 2018

nigurr commented Apr 17, 2018 • edited Loading

jinujoseph commented Apr 17, 2018

heejaechang commented Apr 17, 2018 • edited by jinujoseph Loading

Pilchie commented Apr 17, 2018

Pilchie commented Apr 17, 2018

brettfo commented Apr 17, 2018 • edited Loading

heejaechang commented Apr 17, 2018

brettfo commented Apr 17, 2018

nigurr commented Apr 18, 2018 • edited Loading

jinujoseph commented Apr 18, 2018

brettfo commented May 2, 2018

heejaechang commented Apr 17, 2018 •

edited

Loading

nigurr commented Apr 17, 2018 •

edited

Loading

heejaechang commented Apr 17, 2018 •

edited by jinujoseph

Loading

brettfo commented Apr 17, 2018 •

edited

Loading

nigurr commented Apr 18, 2018 •

edited

Loading