-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve implied lambda and delegate argument names #15277
Conversation
Is |
Uh, it should run differently built fcs, I can look into it tomorrow. |
Got it, desktop test options do not specify preview for the checking of scripts, so I forced it for the 2 tests in question. |
Yep, the current passing of langversion:preview looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kerams awesome job, thanks a lot for the testing and examples!
If you want to continue working on this (refactoring, perf) - go ahead, otherwise feel free to resolve the comments and merge as-is.
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <[email protected]> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <[email protected]> Co-authored-by: Sudqi <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: kerams <[email protected]>
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <[email protected]> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <[email protected]> Co-authored-by: Sudqi <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: kerams <[email protected]>
Will it be released any time soon? |
Probability should be in the next vs/dotnet release |
Alleviates the problem in #11898 (without direct delegates) and improves fsharp/fslang-suggestions#1083 (comment).
instead of