-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature of nested type with generic type parameter #15259
Conversation
5e644e4
to
d99b563
Compare
Or, even better, you probably can create this nested type and reference it in your test. Update: oh, it just enumerates all files. In this case, it's probably easier to just manually add one separate test, which also references custom C# code, and compiles ( |
A slightly better attempt by storing the generic parameters in |
tests/FSharp.Compiler.ComponentTests/Signatures/NestedTypeTests.fs
Outdated
Show resolved
Hide resolved
This is ready. |
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <[email protected]> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <[email protected]> Co-authored-by: Sudqi <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: kerams <[email protected]>
* add review comment to sb files (#15288) * add review comment to sb files * add CODEOWNERS entry for source-build * Don't show inline hint for arguments with same names as the parameters in DU (#15305) * Signature of nested type with generic type parameter (#15259) * Proof of concept * Add generic parameter names to ModuleOrType. * Revert ModuleOrType change * Process ticks in demangledPath of TType_app. * Only apply new logic when includeStaticParametersInTypeNames is active. * Use FactForNETCOREAPP * Fix build --------- Co-authored-by: Tomas Grosup <[email protected]> * Improve implied lambda and delegate argument names (#15277) * Improve implied lambda and delegate argument names * Fix * Add tests * Revert non-preview tests * Sigh * Re-revert * Fix test * Add testx --------- Co-authored-by: Oleksandr Didyk <[email protected]> Co-authored-by: Sudqi <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: kerams <[email protected]>
When trying to create a signature for:
the compiler generates:
System.Collections.Immutable.ImmutableArray`1.Builder<'T>
is the problematic bit,it should be
System.Collections.Immutable.ImmutableArray<'T>.Builder
.I'm guessing Builder is a nested class?
My initial fix is not the way to go. And I could use a tip on how to tackle this in a nicer way.
I'm all hears 😇.
PS: @T-Gro I think my test will only work on net7.0, any pointers on how to address that?