Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyManager] Possible deadlock reading stdout and stderr #10665

Closed
jonsequitur opened this issue Dec 9, 2020 · 0 comments · Fixed by #10716
Closed

[DependencyManager] Possible deadlock reading stdout and stderr #10665

jonsequitur opened this issue Dec 9, 2020 · 0 comments · Fixed by #10716

Comments

@jonsequitur
Copy link
Contributor

Please provide a succinct description of the issue.

The pattern for consuming stdout and stderr from a child process could lead to a deadlock here:

let stdOut = drainStreamToMemory p.StandardOutput
let stdErr = drainStreamToMemory p.StandardError

Provide the steps required to reproduce the problem:

Conditions that can lead to a deadlock are documented here: https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.standardoutput?view=net-5.0#remarks

It's possible that this is implicated in frequent deadlocks we've been seeing in the .NET Interactive CI pipeline but they're not reproducible elsewhere, so I'm speculating.

KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Dec 13, 2020
KevinRansom added a commit that referenced this issue Dec 14, 2020
* fix 10665 - Possible deadlock reading stdout and stderr #10665

* Add timeout to resolve api

* validation

* surface area

* FSharpqa test
KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Dec 15, 2020
KevinRansom added a commit that referenced this issue Dec 15, 2020
* Fix #10665 --- for test framework

* Update test framework
nosami pushed a commit to xamarin/visualfsharp that referenced this issue Feb 23, 2021
* fix 10665 - Possible deadlock reading stdout and stderr dotnet#10665

* Add timeout to resolve api

* validation

* surface area

* FSharpqa test
nosami pushed a commit to xamarin/visualfsharp that referenced this issue Feb 23, 2021
* Fix dotnet#10665 --- for test framework

* Update test framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant