Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system-command-line version #1436

Merged

Conversation

MichaelSimons
Copy link
Member

This is update is needed for source-build. The dotnet/sdk repo updated their version which determines the version included in source-build. There was an breaking api change therefore breaking the templating build in source-build.

@ghost ghost added the Community label Nov 19, 2021
@JoeRobich
Copy link
Member

@MichaelSimons Thanks for opening. I'll have to look into why our subscription didn't generate an update.

@JoeRobich
Copy link
Member

Hmm.. Looks like this moves us to a version that hasn't been published to the .NET 6 channel. Is that expected?

@MichaelSimons
Copy link
Member Author

@sfoslund - Can you respond to @JoeRobich's question about why the command-line-api version the SDK upgraded to hasn't been published to the .NET 6 channel?

@sfoslund
Copy link
Member

I believe System.CommandLine is published to the .NET Libraries channel, is that right @jonsequitur?

@JoeRobich
Copy link
Member

JoeRobich commented Nov 19, 2021

@sfoslund I was just trying to follow the SDK's subscriptions and they aren't using the .NET Libraries channel yet. I will update format's subscriptions. Thanks!

@sfoslund
Copy link
Member

I was just trying to follow the SDK's subscriptions and they aren't using the .NET Libraries channel yet.

Oops, thanks for pointing that out, I've updated the SDK subscriptions and made sure that they are working now: dotnet/sdk#22693 dotnet/sdk#22694

@JoeRobich JoeRobich merged commit 27f21b0 into dotnet:release/6.x Nov 19, 2021
@MichaelSimons MichaelSimons deleted the upgrade-system-command-line branch November 23, 2021 18:02
JoeRobich added a commit to JoeRobich/format that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants