Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to #26353 - Test Subquery_with_Distinct_Skip_FirstOrDefault_without_OrderBy is non-deterministic #26363

Merged
1 commit merged into from
Oct 15, 2021

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Oct 15, 2021

added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353

@ghost
Copy link

ghost commented Oct 15, 2021

Hello @maumar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@maumar
Copy link
Contributor Author

maumar commented Oct 15, 2021

@msftbot require 1 approval

@ghost
Copy link

ghost commented Oct 15, 2021

Hello @maumar!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@maumar maumar changed the title Fix to #26353 - Fix to #26353 - Test Subquery_with_Distinct_Skip_FirstOrDefault_without_OrderBy is non-deterministic Oct 15, 2021
…ut_OrderBy is non-deterministic

added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353
@ghost
Copy link

ghost commented Oct 15, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit bb46c5e into main Oct 15, 2021
@ghost ghost deleted the fix26353 branch October 15, 2021 23:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Subquery_with_Distinct_Skip_FirstOrDefault_without_OrderBy is non-deterministic
2 participants