Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Subquery_with_Distinct_Skip_FirstOrDefault_without_OrderBy is non-deterministic #26353

Closed
roji opened this issue Oct 14, 2021 · 3 comments · Fixed by #26363
Closed

Test Subquery_with_Distinct_Skip_FirstOrDefault_without_OrderBy is non-deterministic #26353

roji opened this issue Oct 14, 2021 · 3 comments · Fixed by #26363
Assignees
@maumar
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Oct 14, 2021

It seems this test generates non-deterministic results by design (omitting OrderBy), and ordering on the client isn't an option here. Should we convert this test to not use AssertQuery?

/cc @maumar @smitpatel
@maumar
Copy link
Contributor

maumar commented Oct 14, 2021

makes sense

@maumar maumar self-assigned this Oct 14, 2021
@smitpatel
Copy link
Contributor

We can still use AssertQuery for ease of writing and add element asserter to skip the check of elements inside collection.

@maumar
Copy link
Contributor

maumar commented Oct 15, 2021

I was thinking that too @smitpatel

maumar added a commit that referenced this issue Oct 15, 2021
@maumar
Fix to #26353 -
eee9721 
added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353
@maumar maumar mentioned this issue Oct 15, 2021
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2021
maumar added a commit that referenced this issue Oct 15, 2021
@maumar
Fix to #26353 - Test Subquery_with_Distinct_Skip_FirstOrDefault_witho…
539e415 
…ut_OrderBy is non-deterministic

added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353
@ajcvickers ajcvickers added this to the MQ milestone Oct 15, 2021
maumar added a commit that referenced this issue Oct 15, 2021
@maumar
Fix to #26353 - Test Subquery_with_Distinct_Skip_FirstOrDefault_witho…
87e1aaa 
…ut_OrderBy is non-deterministic

added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353
@ghost ghost closed this as completed in #26363 Oct 15, 2021
ghost pushed a commit that referenced this issue Oct 15, 2021
@maumar
Fix to #26353 - Test Subquery_with_Distinct_Skip_FirstOrDefault_witho…
bb46c5e 
…ut_OrderBy is non-deterministic (#26363)

added way to order on the client on the top level but don't actually verify the subquery result, because its not deterministic.

Fixes #26353
@maumar maumar modified the milestones: MQ, 7.0.0 Oct 16, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
4 participants
@ajcvickers @smitpatel @maumar @roji