Update AppServiceProviderFactory to use WebHostFactoryResolver #10100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Oct 20, 2017
| _reporter.WriteVerbose(DesignStrings.NoBuildWebHost(webHostFactoryResult.ProgramType.DisplayName())); | ||
| return null; | ||
| default: | ||
| throw new InvalidOperationException("Can't get here."); |
There was a problem hiding this comment.
I prefer this pattern:
Debug.Fail("Unexpected value: " + webHostFactoryResult.ResultKind);
return null;| var programType = FindProgramClass(); | ||
| if (programType == null) | ||
| var webHostFactoryResult = WebHostFactoryResolver.ResolveWebHostFactory<object, object>(_startupAssembly); | ||
| switch (webHostFactoryResult.ResultKind) |
There was a problem hiding this comment.
It may not be important to preserve all these messages. If you think it's more maintainable to replace them with a generic "can't find web host factory" message, I won't push back.
javiercn
force-pushed
the
javiercn/webhost-refactor
branch
from
d90ad06 to
28a5815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new shared sources package we created to abstract the aspnet templates host initialization logic. It finds either
IWebHostBuilder CreateWebHostBuilder(string[] args) or
IWebHost BuildWebHost(string[] args)
and provides a factory method that can be used to produce an IWebHost instance