-
Notifications
You must be signed in to change notification settings - Fork 79
Update templates to support the new pattern used for integration tests #78
Conversation
@javiercn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my understanding of what this ought to look like, this is good.
} | ||
|
||
public static IWebHost BuildWebHost(string[] args) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this break EF tooling? /cc @bricelam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe EF tooling was updated by @javiercn .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so EF tooling now supports both patterns? So, this change will work with EF Core 2.1, but not with 2.0, but an app created using the 2.0 pattern will continue to work with 2.1? If so, I think that's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, do the SPA templates need to be updated? E.g. https://github.com/aspnet/templating/blob/dev/src/Microsoft.DotNet.Web.Spa.ProjectTemplates/content/Angular-CSharp/Program.cs#L15-L23
@Eilon Any changes to the .NET parts of the project templates should be applied to the SPA ones at the same time, yes. |
@SteveSandersonMS I've updated the spa templates with the new pattern. |
@@ -13,14 +13,13 @@ open Microsoft.Extensions.Logging | |||
module Program = | |||
let exitCode = 0 | |||
|
|||
let BuildWebHost args = | |||
let CreateWebHostBuilder args = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very... nice?? 😄
c76c452
to
f005434
Compare
I tried running the EF tools with both patterns to verify that they both work. Below is the output