support multiple versions build #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
|
Seems that we need to rebase this PR together as there're too many conflicts 😂 |
| exclude | The files to be excluded, `glob` pattern is supported. | ||
| ~~cwd~~ | **Obsoleted**, please use `src`. | ||
| src | Specifies the source directory. If omitted, the directory of the config file will be used. Use this option when you want to refer to files in relative folders while want to keep folder structure. e.g. set `src` to `..`. | ||
| dest | The folder name for the generated files. | ||
| version | Version name for the current file mapping. If not set, treat the current file-mapping item as in global version. Mappings with the same version name will be built together. Cross reference doesn't support cross different versions. |
There was a problem hiding this comment.
global version -> default version?
|
|
| }; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
These three code pieces are similar, is it possible to refactor?
There was a problem hiding this comment.
Refactored. Change FileMappingParameters to a dictionary, so the property can be converted to a key as a parameter.
| using (new PerformanceScope("building documents", LogLevel.Info)) | ||
| { | ||
| builder.Build(parameters); | ||
| foreach (var parameters in ConfigToParameter(config, templateManager, baseDirectory, outputDirectory)) | ||
| { |
There was a problem hiding this comment.
question: seems build per version, so currently we still couldn't handle cross version reference case?
There was a problem hiding this comment.
|
👍 |
|
|
|
Please is there a way to build just a particular version to prevent other API versions from rebuilding? @superyyrrzz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#396
@chenkennt @vwxyzh @ansyral @qinezh @hellosnow
sample docfx.json:
{ "build": { "content": [ { "files": "*.yml", "src": "v2.0", "dest": "v2.0/api", "version": "v2.0" }, { "files": "*.yml", "src": "v2.1", "dest": "v2.1/api", "version": "v2.1" }, { "files": "conceptual/*.md", "src": "v2.0", "dest": "v2.0", "version": "v2.0" }, { "files": "conceptual/*.md", "src": "v2.1", "dest": "v2.1", "version": "v2.1" }, { "files": "index.md" } ], "dest": "_site" } }