Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does PR 477 to support versioning really do? #5218

Closed
thuannguy opened this issue Oct 21, 2019 · 2 comments
Closed

What does PR 477 to support versioning really do? #5218

thuannguy opened this issue Oct 21, 2019 · 2 comments

Comments

@thuannguy
Copy link

thuannguy commented Oct 21, 2019

I'm trying the (limited) versioning feature that is supported by #477

What I don't understand from reading the PR as well as related issue is that what it exactly does.

{
  "build": {
    "content": [
      {
        "files": "*.yml",
        "src": "v2.0",
        "dest": "v2.0/api",
        "version": "v2.0"
      },
      {
        "files": "*.yml",
        "src": "v2.1",
        "dest": "v2.1/api",
        "version": "v2.1"
      },
      {
        "files": "conceptual/*.md",
        "src": "v2.0",
        "dest": "v2.0",
        "version": "v2.0"
      },
      {
        "files": "conceptual/*.md",
        "src": "v2.1",
        "dest": "v2.1",
        "version": "v2.1"
      },
      {
        "files": "index.md"
      }
    ],
    "dest": "_site"
  }
} 

It seems to me that I still have to have separate data folders for each version. So what is the improvement versus:

{
  "build": {
    "content": [
      {
        "files": "conceptualv2.0/*.md"
      },
      {
        "files": "conceptualv2.1/*.md"
      },
      {
        "files": "index.md"
      }
    ],
    "dest": "_site"
  }
} 

Here I have two separate folders (conceptualv2.0, conceptualv2.1) to store 2 versions of my docs.

@superyyrrzz
Copy link
Contributor

If you only have conceptual Markdown files, I think there is no improvement. If you have multiple versions of the same code base, say multiple YAMLs, you can use this to avoid UID conflict.

@stale
Copy link

stale bot commented Jan 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the stale label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants