Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedscope format contains invalid json #623

Closed
tmds opened this issue Nov 18, 2019 · 4 comments · Fixed by #661
Closed

speedscope format contains invalid json #623

tmds opened this issue Nov 18, 2019 · 4 comments · Fixed by #661
Labels
bug Something isn't working tracking-external-issue
Milestone

Comments

@tmds
Copy link
Member

tmds commented Nov 18, 2019

Steps to reproduce:

                    using var httpClient = new HttpClient();
                    string response = await httpClient.GetStringAsync("http://redhatloves.net/");

Log with --providers Microsoft-System-Net-Http --format speedscope

The resulting json file is invalid because newlines are not escaped in json strings.

For example:

{ "name": "EventData: parameters=(Method: GET, RequestUri: 'http://redhatloves.net/', Version: 1.1, Content: <null>, Headers:
{
})" }
@tmds
Copy link
Member Author

tmds commented Nov 18, 2019

cc @adamsitnik

@hoyosjs
Copy link
Member

hoyosjs commented Nov 18, 2019

@josalem

@josalem
Copy link
Contributor

josalem commented Nov 18, 2019

Tracking fix in: microsoft/perfview#1057

@adamsitnik
Copy link
Member

I've submitted a fix in #661

@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working tracking-external-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants