SpeedScopeStackSource fails to escape new-lines in json

[josalem]

Original issue in dotnet/diagnostics:

Steps to reproduce:

                    using var httpClient = new HttpClient();
                    string response = await httpClient.GetStringAsync("http://redhatloves.net/");

Log with --providers Microsoft-System-Net-Http --format speedscope

The resulting json file is invalid because newlines are not escaped in json strings.

For example:

{ "name": "EventData: parameters=(Method: GET, RequestUri: 'http://redhatloves.net/', Version: 1.1, Content: <null>, Headers:
{
})" }

Original comment by: @tmds

dotnet/diagnostics#623

Should just be a matter of adding encoding logic to the JSON writing logic. Could use the new System.Text.Json API which is available as a nuget package to older versions of the runtime.

CC - @adamsitnik

[adamsitnik]

It was possible to fix the problem in dotnet trace: dotnet/diagnostics#661

IMHO this issue can be closed. Or I can add a very defensive condition to SpeedScopeStackSourceWriter (I would prefer not to do it)

[josalem]

I think the fix is dotnet/diagnostics is sufficient. Thanks for finding the issue 😃