Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Support for ARM64 on UNIX like systems compiler and runtime #8271

Merged
merged 42 commits into from
Aug 27, 2020

Conversation

RalfKornmannEnvision
Copy link
Contributor

@RalfKornmannEnvision RalfKornmannEnvision commented Aug 20, 2020

Implements most of the missing parts for ARM64 on UNIX like hosts.

  • Change section for native signature layout from read only to data for non Windows systems to avoid linker issues with absolute relocations between sections
  • Store CFI data for ARM64 non Windows builds
  • Add special ARM64 relocation types were needed
  • Implements functions to handle 28 bit offsets in ARM64 opcodes
  • Implements ARM64 instruction encoding
  • Implements helper nodes ARM64 code generators
  • Implements ARM64 intrinsic supports by following the XArch pattern
  • Implements runtime query and check of required intrinsics
  • Use special name for AssignRef helper functions as RyuJit uses a custom calling convention for these on ARM64
  • Change relocation type for exception type in catch handler to avoid an assert in LLVM. The old one marked the symbol as code but it's data.
  • Fix the runtime to handle the new relocation type correct
  • Add post processing for ARM64 CFI data to ensure the unwinder can use them.
  • patch LLVM to handle ARM64 relocations in the way the object writer emits them
  • Add ARM64 ELF support to the object writer
  • Port syntax for all needed assembler functions (*.asm to *.S)
  • Implements new unwind helper that follows the AMD64 model (Shim over REGDISPLAY)
  • Add option to use only the dwarf index to search for unwind information. Needed when the linker removed anything else for different reasons.

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants
* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception
* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception
* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 formating

* ARM64: revert using alternative JIT

* Revert "ARM64 unix stack walk"

This reverts commit 6c9e235.
@RalfKornmannEnvision RalfKornmannEnvision marked this pull request as ready for review August 20, 2020 08:41
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the AOT compiler changes so far, but looks great!

I'll look at the rest a bit later.

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 formating

* ARM64: revert using alternative JIT

* Revert "ARM64 unix stack walk"

* ARM64 review reworks
Arm64: Fix function call for pinvoke result
Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs
ARM64: Ensure module fixup node data is aligned
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great otherwise! Thank you!

src/Native/libunwind/src/UnwindCursor.hpp Outdated Show resolved Hide resolved
src/JitInterface/src/CorInfoImpl.cs Show resolved Hide resolved
src/JitInterface/src/CorInfoImpl.cs Outdated Show resolved Hide resolved
src/Native/Runtime/arm64/AllocFast.S Outdated Show resolved Hide resolved
src/Native/Runtime/arm64/ExceptionHandling.S Outdated Show resolved Hide resolved
src/Native/Runtime/unix/unixasmmacrosarm64.inc Outdated Show resolved Hide resolved
src/Native/ObjWriter/objwriter.cpp Outdated Show resolved Hide resolved
src/Native/Runtime/arm64/PInvoke.S Outdated Show resolved Hide resolved
src/Native/Runtime/arm64/StubDispatch.S Outdated Show resolved Hide resolved
src/Native/Runtime/arm64/WriteBarriers.S Show resolved Hide resolved
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the assembly helpers in detail, but the rest looks good! Thanks!

src/Native/ObjWriter/objwriter.cpp Outdated Show resolved Hide resolved
* ARM64: remove left over code
@jkotas jkotas merged commit c01d95a into dotnet:master Aug 27, 2020
@jkotas
Copy link
Member

jkotas commented Aug 27, 2020

@RalfKornmannEnvision Thank you again for this contribution! We really appreciate it.

RalfKornmannEnvision added a commit to RalfKornmannEnvision/corert that referenced this pull request Aug 28, 2020
* Fix alignment of marshaled inline arrays (dotnet#8275)

Fixes dotnet#8274

* Correct flags for allocating in RhpNewFastMisalign.  Add fast path (dotnet#8277)

* add switch case for LPUTF8Str in array element (dotnet#8278)

* Wasm: Add support for DefaultConstructorOf and hence Activator.CreateInstance<T> (dotnet#8279)

* Wasm: upgrade emscripten for an llvm and exception fixes. (dotnet#8281)

* upgrade emscripten for some llvm and exception fixes.

Correct retrieval of exception from landing pad.
end c++ exception when catch found.

* Update ILToWebAssemblyImporter.cs

remove cut/past comment

* Wasm: add support for new StackTrace().ToString() (dotnet#8201)

* wasm add rethrow support (dotnet#8206)

* Wasm: add support for overflow checks on signed and unsigned ints multiply (dotnet#8259)

* wasm-ovf-unsigned-int

* refactor for stack kind tests and add signed check

* use llvm intrinsics

* Wasm: bring add and sub overflow operations in line with mul (dotnet#8284)

* Support for ARM64 on UNIX like systems compiler and runtime (dotnet#8271)

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implementations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decoding

* Move native layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the generic helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 Fix wrong function call for invoke return

* ARM64: Ensure module fixup node data is aligned

Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs

* Wasm fix LLVM Debug Information subroutine linkage (dotnet#8288)

* wasm - reinstate llvm debug subroutine linkage

Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: yowl <[email protected]>
RalfKornmannEnvision added a commit to RalfKornmannEnvision/corert that referenced this pull request Aug 28, 2020
* Arm64 (#5)

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* Arm64 (#6)

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 formating

* ARM64: revert using alternative JIT

* Revert "ARM64 unix stack walk"

This reverts commit 6c9e235.

* Arm64 (#7)

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decodeing

* Move nattive layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the gemeric helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 formating

* ARM64: revert using alternative JIT

* Revert "ARM64 unix stack walk"

* ARM64 review reworks

* Arm64: review reworks (#10)

* Arm64 (#11)

* ARM64: remove left over code

* Update src/Native/Runtime/arm64/WriteBarriers.S

* Sync to head (#12)

* Fix alignment of marshaled inline arrays (dotnet#8275)

Fixes dotnet#8274

* Correct flags for allocating in RhpNewFastMisalign.  Add fast path (dotnet#8277)

* add switch case for LPUTF8Str in array element (dotnet#8278)

* Wasm: Add support for DefaultConstructorOf and hence Activator.CreateInstance<T> (dotnet#8279)

* Wasm: upgrade emscripten for an llvm and exception fixes. (dotnet#8281)

* upgrade emscripten for some llvm and exception fixes.

Correct retrieval of exception from landing pad.
end c++ exception when catch found.

* Update ILToWebAssemblyImporter.cs

remove cut/past comment

* Wasm: add support for new StackTrace().ToString() (dotnet#8201)

* wasm add rethrow support (dotnet#8206)

* Wasm: add support for overflow checks on signed and unsigned ints multiply (dotnet#8259)

* wasm-ovf-unsigned-int

* refactor for stack kind tests and add signed check

* use llvm intrinsics

* Wasm: bring add and sub overflow operations in line with mul (dotnet#8284)

* Support for ARM64 on UNIX like systems compiler and runtime (dotnet#8271)

* CoreRT-ARM64: Helper node asm code generation

* CoreRT ARM64: Add additional relocation support

* CoreRT ARM64: Use alternative functions for write Barriers

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implementations. The helper nodes need to call the custom variants

* ARM64 code generation

* unwind use only the dwarf index option

* ARM64 runtime assembler functions

* ARM64 unix stack walk

* ARM64 Exception Handling

* ARM64: Fix EH data decoding

* Move native layout signature from read only to data section on non Windows target

* Fix exception handling macro call

* ARM64 thunk helpers

* ARM64 process cfi data for elf

* ARM64 missing assembler macro

* ARM64 port more assembler helpers

* ARM64: Add missing case for the generic helper node

* ARM64 intrinsic support

* ARM64 object writer for ELF object files

* ARM64 llvm patches for object writer

* ARM64 include untested helper code with debug break

* ARM64 reenable scanning fail exception

* ARM64 Fix wrong function call for invoke return

* ARM64: Ensure module fixup node data is aligned

Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs

* Wasm fix LLVM Debug Information subroutine linkage (dotnet#8288)

* wasm - reinstate llvm debug subroutine linkage

Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: yowl <[email protected]>

Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: yowl <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants